lib: reduce URL invocations on http2 origins

PR-URL: #48338 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>

Author: anonrig

lib/internal/http2/core.js

@@ -45,7 +45,7 @@ const EventEmitter = require('events');
 constfs=require('fs');
 consthttp=require('http');
 const{ readUInt16BE, readUInt32BE }=require('internal/buffer');
-const{URL}=require('internal/url');
+const{URL, getURLOrigin}=require('internal/url');
 constnet=require('net');
 const{ Duplex }=require('stream');
 consttls=require('tls');
@@ -636,7 +636,7 @@ function initOriginSet(session){
 // We have to ensure that it is a properly serialized
 // ASCII origin string. The socket.servername might not
 // be properly ASCII encoded.
-originSet.add((newURL(originString)).origin);
+originSet.add(getURLOrigin(originString));
 }
 }
 returnoriginSet;
@@ -1641,7 +1641,7 @@ class ServerHttp2Session extends Http2Session{
 letorigin;
 
 if(typeoforiginOrStream==='string'){
-origin=(newURL(originOrStream)).origin;
+origin=getURLOrigin(originOrStream);
 if(origin==='null')
 thrownewERR_HTTP2_ALTSVC_INVALID_ORIGIN();
 }elseif(typeoforiginOrStream==='number'){
@@ -1693,7 +1693,7 @@ class ServerHttp2Session extends Http2Session{
 for(leti=0;i<count;i++){
 letorigin=origins[i];
 if(typeoforigin==='string'){
-origin=(newURL(origin)).origin;
+origin=getURLOrigin(origin);
 }elseif(origin!=null&&typeoforigin==='object'){
 origin=origin.origin;
 }

lib/internal/url.js

@@ -1436,6 +1436,16 @@ function toPathIfFileURL(fileURLOrPath){
 returnfileURLToPath(fileURLOrPath);
 }
 
+/**
+ * This util takes a string containing a URL and return the URL origin,
+ * its meant to avoid calls to `new URL` constructor.
+ * @param{string} url
+ * @returns{URL['origin']}
+ */
+functiongetURLOrigin(url){
+returnbindingUrl.getOrigin(url);
+}
+
 module.exports={
  toUSVString,
  fileURLToPath,
@@ -1451,4 +1461,5 @@ module.exports ={
  isURL,
 
 urlUpdateActions: updateActions,
+ getURLOrigin,
 };

src/node_errors.h

@@ -74,6 +74,7 @@ void AppendExceptionLine(Environment* env,
 V(ERR_INVALID_STATE, Error) \
 V(ERR_INVALID_THIS, TypeError) \
 V(ERR_INVALID_TRANSFER_OBJECT, TypeError) \
+V(ERR_INVALID_URL, TypeError) \
 V(ERR_MEMORY_ALLOCATION_FAILED, Error) \
 V(ERR_MESSAGE_TARGET_CONTEXT_UNAVAILABLE, Error) \
 V(ERR_MISSING_ARGS, TypeError) \

src/node_url.cc

@@ -117,6 +117,30 @@ void BindingData::DomainToUnicode(const FunctionCallbackInfo<Value>& args){
  .ToLocalChecked());
 }
 
+voidBindingData::GetOrigin(const v8::FunctionCallbackInfo<Value>& args){
+CHECK_GE(args.Length(), 1);
+CHECK(args[0]->IsString()); // input
+
+ Environment* env = Environment::GetCurrent(args);
+ HandleScope handle_scope(env->isolate());
+
+ Utf8Value input(env->isolate(), args[0]);
+ std::string_view input_view = input.ToStringView();
+auto out = ada::parse<ada::url_aggregator>(input_view);
+
+if (!out){
+THROW_ERR_INVALID_URL(env, "Invalid URL");
+return;
+ }
+
+ std::string origin = out->get_origin();
+ args.GetReturnValue().Set(String::NewFromUtf8(env->isolate(),
+ origin.data(),
+ NewStringType::kNormal,
+ origin.length())
+ .ToLocalChecked());
+}
+
 voidBindingData::CanParse(const FunctionCallbackInfo<Value>& args){
 CHECK_GE(args.Length(), 1);
 CHECK(args[0]->IsString()); // input
@@ -322,6 +346,7 @@ void BindingData::CreatePerIsolateProperties(IsolateData* isolate_data,
 SetMethodNoSideEffect(isolate, target, "domainToASCII", DomainToASCII);
 SetMethodNoSideEffect(isolate, target, "domainToUnicode", DomainToUnicode);
 SetMethodNoSideEffect(isolate, target, "format", Format);
+SetMethodNoSideEffect(isolate, target, "getOrigin", GetOrigin);
 SetMethod(isolate, target, "parse", Parse);
 SetMethod(isolate, target, "update", Update);
 SetFastMethodNoSideEffect(
@@ -341,6 +366,7 @@ void BindingData::RegisterExternalReferences(
  registry->Register(DomainToASCII);
  registry->Register(DomainToUnicode);
  registry->Register(Format);
+ registry->Register(GetOrigin);
  registry->Register(Parse);
  registry->Register(Update);
  registry->Register(CanParse);

src/node_url.h

@@ -53,6 +53,7 @@ class BindingData : public SnapshotableObject{
 const v8::FastOneByteString& input);
 
 staticvoidFormat(const v8::FunctionCallbackInfo<v8::Value>& args);
+staticvoidGetOrigin(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidParse(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidUpdate(const v8::FunctionCallbackInfo<v8::Value>& args);