stream: do not defer construction by one microtick

Fixes: #51993 PR-URL: #52005 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: mcollina

lib/internal/streams/destroy.js

@@ -291,7 +291,7 @@ function constructNT(stream){
 }elseif(err){
 errorOrDestroy(stream,err,true);
 }else{
-process.nextTick(emitConstructNT,stream);
+stream.emit(kConstruct);
 }
 }
 
@@ -304,10 +304,6 @@ function constructNT(stream){
 }
 }
 
-functionemitConstructNT(stream){
-stream.emit(kConstruct);
-}
-
 functionisRequest(stream){
 returnstream?.setHeader&&typeofstream.abort==='function';
 }

test/parallel/test-fs-writestream-open-write.js

@@ -0,0 +1,28 @@
+'use strict';
+
+constcommon=require('../common');
+consttmpdir=require('../common/tmpdir');
+const{ strictEqual }=require('assert');
+constfs=require('fs');
+
+// Regression test for https://github.com/nodejs/node/issues/51993
+
+tmpdir.refresh();
+
+constfile=tmpdir.resolve('test-fs-writestream-open-write.txt');
+
+constw=fs.createWriteStream(file);
+
+w.on('open',common.mustCall(()=>{
+w.write('hello');
+
+process.nextTick(()=>{
+w.write('world');
+w.end();
+});
+}));
+
+w.on('close',common.mustCall(()=>{
+strictEqual(fs.readFileSync(file,'utf8'),'helloworld');
+fs.unlinkSync(file);
+}));