test: refactor test-net-connect-memleak, move to parallel

This enables the test to run as part of the regular test suite. PR-URL: #21794 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: addaleax

test/pummel/test-net-connect-memleak.js test/parallel/test-net-connect-memleak.jstest/pummel/test-net-connect-memleak.js renamed to test/parallel/test-net-connect-memleak.js

@@ -26,32 +26,32 @@ const common = require('../common');
 constassert=require('assert');
 constnet=require('net');
 
-console.log('Run this test with --expose-gc');
-assert.strictEqual(
-typeofglobal.gc,
-'function'
-);
-net.createServer(function(){}).listen(common.PORT);
-
-letbefore=0;
+// Test that the implicit listener for an 'connect' event on net.Sockets is
+// added using `once()`, i.e. can be gc'ed once that event has occurred.
+
+constserver=net.createServer(common.mustCall()).listen(0);
+
+letcollected=false;
+constgcListener={ongc(){collected=true;}};
+
 {
-// 2**26 == 64M entries
-global.gc();
-constjunk=newArray(2**26).fill(0);
-before=process.memoryUsage().rss;
+constgcObject={};
+common.onGC(gcObject,gcListener);
 
-net.createConnection(common.PORT,'127.0.0.1',function(){
-assert.notStrictEqual(junk.length,0);// keep reference alive
-setTimeout(done,10);
-global.gc();
-});
+constsock=net.createConnection(
+server.address().port,
+common.mustCall(()=>{
+assert.strictEqual(gcObject,gcObject);// keep reference alive
+assert.strictEqual(collected,false);
+setImmediate(done,sock);
+}));
 }
 
-functiondone(){
+functiondone(sock){
 global.gc();
-constafter=process.memoryUsage().rss;
-constreclaimed=(before-after)/1024;
-console.log('%d kB reclaimed',reclaimed);
-assert(reclaimed>128*1024);// It's around 256 MB on x64.
-process.exit();
+setImmediate(()=>{
+assert.strictEqual(collected,true);
+sock.end();
+server.close();
+});
 }