test: skip test if in FreeBSD jail

Test test-net-socket-local-address is flaky in FreeBSD jail but robust otherwise. Fixes: #2475 PR-URL: #3995 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: Trott

test/parallel/parallel.status

@@ -19,4 +19,3 @@ test-child-process-exit-code : PASS,FLAKY
 [$system==solaris] # Also applies to SmartOS
 
 [$system==freebsd]
-test-net-socket-local-address : PASS,FLAKY

test/parallel/test-net-socket-local-address.js

@@ -1,24 +1,30 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
-varnet=require('net');
+constcommon=require('../common');
+constassert=require('assert');
+constnet=require('net');
+
+// skip test in FreeBSD jails
+if(common.inFreeBSDJail){
+console.log('1..0 # Skipped: In a FreeBSD jail');
+return;
+}
 
 varconns=0;
 varclientLocalPorts=[];
 varserverRemotePorts=[];
 
-varserver=net.createServer(function(socket){
+constserver=net.createServer(function(socket){
 serverRemotePorts.push(socket.remotePort);
 conns++;
 });
 
-varclient=newnet.Socket();
+constclient=newnet.Socket();
 
-server.on('close',function(){
+server.on('close',common.mustCall(function(){
 assert.deepEqual(clientLocalPorts,serverRemotePorts,
 'client and server should agree on the ports used');
 assert.equal(2,conns);
-});
+}));
 
 server.listen(common.PORT,common.localhostIPv4,testConnect);