repl: make key of repl.write() optional always

In `.editor` mode, `repl.write()` would have crashed when the `key` argument was not present, because the overwritten `_ttyWrite` of REPLs doesn’t check for the absence of a second argument like `readline.write()` does. Since the docs indicate that the argument is optional, add a check paralleling the one in `readline.write()`. PR-URL: #9207 Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: addaleax

lib/repl.js

@@ -601,6 +601,7 @@ function REPLServer(prompt,
 // Wrap readline tty to enable editor mode
 constttyWrite=self._ttyWrite.bind(self);
 self._ttyWrite=(d,key)=>{
+key=key||{};
 if(!self.editorMode||!self.terminal){
 ttyWrite(d,key);
 return;

test/parallel/test-repl-.editor.js

@@ -8,16 +8,17 @@ const repl = require('repl');
 // \u001b[0J - Clear screen
 // \u001b[3G - Moves the cursor to 3rd column
 constterminalCode='\u001b[1G\u001b[0J> \u001b[3G';
+constterminalCodeRegex=newRegExp(terminalCode.replace(/\[/g,'\\['),'g');
 
-functionrun({input, output, event}){
+functionrun({input, output, event, checkTerminalCodes =true}){
 conststream=newcommon.ArrayStream();
 letfound='';
 
 stream.write=(msg)=>found+=msg.replace('\r','');
 
-constexpected=`${terminalCode}.editor\n`+
-'// Entering editor mode (^D to finish, ^C to cancel)\n'+
-`${input}${output}\n${terminalCode}`;
+letexpected=`${terminalCode}.editor\n`+
+'// Entering editor mode (^D to finish, ^C to cancel)\n'+
+`${input}${output}\n${terminalCode}`;
 
 constreplServer=repl.start({
 prompt: '> ',
@@ -31,6 +32,12 @@ function run({input, output, event}){
 stream.emit('data',input);
 replServer.write('',event);
 replServer.close();
+
+if(!checkTerminalCodes){
+found=found.replace(terminalCodeRegex,'').replace(/\n/g,'');
+expected=expected.replace(terminalCodeRegex,'').replace(/\n/g,'');
+}
+
 assert.strictEqual(found,expected);
 }
 
@@ -54,6 +61,12 @@ const tests = [
 input: ' var i = 1;\ni + 3',
 output: '\n4',
 event: {ctrl: true,name: 'd'}
+},
+{
+input: '',
+output: '',
+checkTerminalCodes: false,
+event: null,
 }
 ];