test: refactor common.expectsError

A combination of try catch and common.expectsError is not necessary as the latter already does everything on its own. Backport-PR-URL: #19230 PR-URL: #17703 Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: BridgeAR

test/parallel/test-assert.js

@@ -476,33 +476,21 @@ common.expectsError(
 }
 );
 
-{
-letthrew=false;
-try{
-assert.doesNotThrow(makeBlock(thrower,Error),'user message');
-}catch(e){
-threw=true;
-common.expectsError({
-code: 'ERR_ASSERTION',
-message: /Gotunwantedexception:usermessage\n\[objectObject\]/
-})(e);
+common.expectsError(
+()=>assert.doesNotThrow(makeBlock(thrower,Error),'user message'),
+{
+code: 'ERR_ASSERTION',
+message: /Gotunwantedexception:usermessage\n\[objectObject\]/
 }
-assert.ok(threw);
-}
+);
 
-{
-letthrew=false;
-try{
-assert.doesNotThrow(makeBlock(thrower,Error));
-}catch(e){
-threw=true;
-common.expectsError({
-code: 'ERR_ASSERTION',
-message: /Gotunwantedexception\.\n\[objectObject\]/
-})(e);
+common.expectsError(
+()=>assert.doesNotThrow(makeBlock(thrower,Error)),
+{
+code: 'ERR_ASSERTION',
+message: /Gotunwantedexception\.\n\[objectObject\]/
 }
-assert.ok(threw);
-}
+);
 
 // make sure that validating using constructor really works
 {
@@ -691,21 +679,15 @@ try{
 }
 
 consttestBlockTypeError=(method,block)=>{
-letthrew=true;
-
-try{
-method(block);
-threw=false;
-}catch(e){
-common.expectsError({
+common.expectsError(
+()=>method(block),
+{
 code: 'ERR_INVALID_ARG_TYPE',
 type: TypeError,
 message: 'The "block" argument must be of type Function. Received '+
-`type ${typeName(block)}`
-})(e);
-}
-
-assert.ok(threw);
+`type ${typeName(block)}`
+}
+);
 };
 
 testBlockTypeError(assert.throws,'string');