test: improve buffer transcode

Johnny Reading · Fishrock123 · commit 1f11deb58f92 · 2016-12-13T10:58:01.000-05:00
This test is for argument validation in transcode. PR-URL: #10043 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/test/parallel/test-icu-transcode.js b/test/parallel/test-icu-transcode.js
@@ -38,13 +38,19 @@ for (const test in tests){
 utf8_to_ucs2.toString('ucs2'));
 }
 
+assert.throws(
+ () => buffer.transcode(null, 'utf8', 'ascii'),
+ /^TypeError: "source" argument must be a Buffer$/
+);
+
 assert.throws(
 () => buffer.transcode(Buffer.from('a'), 'b', 'utf8'),
- /Unable to transcode Buffer \[U_ILLEGAL_ARGUMENT_ERROR\]/
+ /^Error: Unable to transcode Buffer \[U_ILLEGAL_ARGUMENT_ERROR\]/
 );
+
 assert.throws(
 () => buffer.transcode(Buffer.from('a'), 'uf8', 'b'),
- /Unable to transcode Buffer \[U_ILLEGAL_ARGUMENT_ERROR\]/
+ /^Error: Unable to transcode Buffer \[U_ILLEGAL_ARGUMENT_ERROR\]$/
 );
 
 assert.deepStrictEqual(

-Original file line number
+Diff line change
 utf8_to_ucs2.toString('ucs2'));
+}
 +assert.throws(
 +()=>buffer.transcode(null,'utf8','ascii'),
 +/^TypeError:"source"argumentmustbeaBuffer$/
 +);
++
 assert.throws(
 ()=>buffer.transcode(Buffer.from('a'),'b','utf8'),
 -/UnabletotranscodeBuffer\[U_ILLEGAL_ARGUMENT_ERROR\]/
 +/^Error:UnabletotranscodeBuffer\[U_ILLEGAL_ARGUMENT_ERROR\]/
 );
++
 assert.throws(
 ()=>buffer.transcode(Buffer.from('a'),'uf8','b'),
 -/UnabletotranscodeBuffer\[U_ILLEGAL_ARGUMENT_ERROR\]/
 +/^Error:UnabletotranscodeBuffer\[U_ILLEGAL_ARGUMENT_ERROR\]$/
 );
 assert.deepStrictEqual(