events: refactor to use primordials in lib/events

Replace code that's vulnerable to Prototype Pollution with Primordials. PR-URL: #38117 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: marsonya

lib/events.js

@@ -22,10 +22,16 @@
 'use strict';
 
 const{
+ ArrayPrototypeIndexOf,
+ ArrayPrototypeJoin,
+ ArrayPrototypeShift,
  ArrayPrototypeSlice,
+ ArrayPrototypeSplice,
  Boolean,
  Error,
  ErrorCaptureStackTrace,
+ FunctionPrototypeBind,
+ FunctionPrototypeCall,
  MathMin,
  NumberIsNaN,
  ObjectCreate,
@@ -38,9 +44,10 @@ const{
  PromiseResolve,
  ReflectOwnKeys,
  String,
+ StringPrototypeSplit,
  Symbol,
  SymbolFor,
- SymbolAsyncIterator
+ SymbolAsyncIterator,
 }=primordials;
 constkRejection=SymbolFor('nodejs.rejection');
 
@@ -265,7 +272,7 @@ EventEmitter.prototype.getMaxListeners = function getMaxListeners(){
 functionidenticalSequenceRange(a,b){
 for(leti=0;i<a.length-3;i++){
 // Find the first entry of b that matches the current entry of a.
-constpos=b.indexOf(a[i]);
+constpos=ArrayPrototypeIndexOf(b,a[i]);
 if(pos!==-1){
 constrest=b.length-pos;
 if(rest>3){
@@ -294,16 +301,18 @@ function enhanceStackTrace(err, own){
 }catch{}
 constsep=`\nEmitted 'error' event${ctorInfo} at:\n`;
 
-consterrStack=err.stack.split('\n').slice(1);
-constownStack=own.stack.split('\n').slice(1);
+consterrStack=ArrayPrototypeSlice(
+StringPrototypeSplit(err.stack,'\n'),1);
+constownStack=ArrayPrototypeSlice(
+StringPrototypeSplit(own.stack,'\n'),1);
 
 const{0: len,1: off}=identicalSequenceRange(ownStack,errStack);
 if(len>0){
-ownStack.splice(off+1,len-2,
-' [... lines matching original stack trace ...]');
+ArrayPrototypeSplice(ownStack,off+1,len-2,
+' [... lines matching original stack trace ...]');
 }
 
-returnerr.stack+sep+ownStack.join('\n');
+returnerr.stack+sep+ArrayPrototypeJoin(ownStack,'\n');
 }
 
 EventEmitter.prototype.emit=functionemit(type, ...args){
@@ -327,7 +336,7 @@ EventEmitter.prototype.emit = function emit(type, ...args){
 constcapture={};
 ErrorCaptureStackTrace(capture,EventEmitter.prototype.emit);
 ObjectDefineProperty(er,kEnhanceStackBeforeInspector,{
-value: enhanceStackTrace.bind(this,er,capture),
+value: FunctionPrototypeBind(enhanceStackTrace,this,er,capture),
 configurable: true
 });
 }catch{}
@@ -620,7 +629,7 @@ EventEmitter.listenerCount = function(emitter, type){
 if(typeofemitter.listenerCount==='function'){
 returnemitter.listenerCount(type);
 }
-returnlistenerCount.call(emitter,type);
+returnFunctionPrototypeCall(listenerCount,emitter,type);
 };
 
 EventEmitter.prototype.listenerCount=listenerCount;
@@ -858,7 +867,7 @@ function on(emitter, event, options){
 }
 
 functioneventHandler(...args){
-constpromise=unconsumedPromises.shift();
+constpromise=ArrayPrototypeShift(unconsumedPromises);
 if(promise){
 promise.resolve(createIterResult(args,false));
 }else{
@@ -869,7 +878,7 @@ function on(emitter, event, options){
 functionerrorHandler(err){
 finished=true;
 
-consttoError=unconsumedPromises.shift();
+consttoError=ArrayPrototypeShift(unconsumedPromises);
 
 if(toError){
 toError.reject(err);