tools: add rule prefering common.mustNotCall()

Prefer using `common.mustNotCall()` over `common.mustCall(fn, 0)` PR-URL: #12027 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>

Author: jasnell

test/.eslintrc.yaml

@@ -9,5 +9,6 @@ rules:
 # Custom rules in tools/eslint-rules
 prefer-assert-iferror: 2
 prefer-assert-methods: 2
+prefer-common-mustnotcall: 2
 ## common module is mandatory in tests
 required-modules: [2, common]

tools/eslint-rules/prefer-common-mustnotcall.js

@@ -0,0 +1,39 @@
+/**
+ * @fileoverview Prefer common.mustNotCall(msg) over common.mustCall(fn, 0)
+ * @author James M Snell <[email protected]>
+ */
+'use strict';
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+constmsg='Please use common.mustNotCall(msg) instead of '+
+'common.mustCall(fn, 0) or common.mustCall(0).';
+
+functionisCommonMustCall(node){
+returnnode&&
+node.callee&&
+node.callee.object&&
+node.callee.object.name==='common'&&
+node.callee.property&&
+node.callee.property.name==='mustCall';
+}
+
+functionisArgZero(argument){
+returnargument&&
+typeofargument.value==='number'&&
+argument.value===0;
+}
+
+module.exports=function(context){
+return{
+CallExpression(node){
+if(isCommonMustCall(node)&&
+(isArgZero(node.arguments[0])||// catch common.mustCall(0)
+isArgZero(node.arguments[1]))){// catch common.mustCall(fn, 0)
+context.report(node,msg);
+}
+}
+};
+};