test: delay loading 'os' in test/common module

There is a test that doesn't load the common module initially because it needs to monkey-patch the 'os' module. I think it would be a good idea to minimize the side-effects of loading common anyway, so let's defer loading 'os' unless/until it's actually needed. PR-URL: #30914 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Author: Trott

test/common/index.js

@@ -23,17 +23,20 @@
 /* eslint-disable node-core/crypto-check */
 'use strict';
 constprocess=global.process;// Some tests tamper with the process global.
-constpath=require('path');
-constfs=require('fs');
+
 constassert=require('assert');
-constos=require('os');
 const{ exec, execSync, spawnSync }=require('child_process');
+constfs=require('fs');
+// Do not require 'os' until needed so that test-os-checked-fucnction can
+// monkey patch it. If 'os' is required here, that test will fail.
+constpath=require('path');
 constutil=require('util');
+const{ isMainThread }=require('worker_threads');
+
 consttmpdir=require('./tmpdir');
 constbits=['arm64','mips','mipsel','ppc64','s390x','x64']
 .includes(process.arch) ? 64 : 32;
 consthasIntl=!!process.config.variables.v8_enable_i18n_support;
-const{ isMainThread }=require('worker_threads');
 
 // Some tests assume a umask of 0o022 so set that up front. Tests that need a
 // different umask will set it themselves.
@@ -102,23 +105,12 @@ if (process.argv.length === 2 &&
 
 constisWindows=process.platform==='win32';
 constisAIX=process.platform==='aix';
-// On IBMi, process.platform and os.platform() both return 'aix',
-// It is not enough to differentiate between IBMi and real AIX system.
-constisIBMi=os.type()==='OS400';
-constisLinuxPPCBE=(process.platform==='linux')&&
-(process.arch==='ppc64')&&
-(os.endianness()==='BE');
 constisSunOS=process.platform==='sunos';
 constisFreeBSD=process.platform==='freebsd';
 constisOpenBSD=process.platform==='openbsd';
 constisLinux=process.platform==='linux';
 constisOSX=process.platform==='darwin';
 
-constenoughTestMem=os.totalmem()>0x70000000;/* 1.75 Gb */
-constcpus=os.cpus();
-constenoughTestCpu=Array.isArray(cpus)&&
-(cpus.length>1||cpus[0].speed>999);
-
 constrootDir=isWindows ? 'c:\\' : '/';
 
 constbuildType=process.config.target_defaults ?
@@ -198,15 +190,6 @@ const PIPE = (() =>{
 returnpath.join(pipePrefix,pipeName);
 })();
 
-consthasIPv6=(()=>{
-constiFaces=os.networkInterfaces();
-constre=isWindows ? /LoopbackPseudo-Interface/ : /lo/;
-returnObject.keys(iFaces).some((name)=>{
-returnre.test(name)&&
-iFaces[name].some(({ family })=>family==='IPv6');
-});
-})();
-
 /*
  * Check that when running a test with
  * `$node --abort-on-uncaught-exception $file child`
@@ -749,8 +732,6 @@ module.exports ={
  childShouldThrowAndAbort,
  createZeroFilledFile,
  disableCrashOnUnhandledRejection,
- enoughTestCpu,
- enoughTestMem,
  expectsError,
  expectsInternalAssertion,
  expectWarning,
@@ -760,14 +741,11 @@ module.exports ={
  getTTYfd,
  hasIntl,
  hasCrypto,
- hasIPv6,
  hasMultiLocalhost,
  isAIX,
  isAlive,
  isFreeBSD,
- isIBMi,
  isLinux,
- isLinuxPPCBE,
  isMainThread,
  isOpenBSD,
  isOSX,
@@ -791,12 +769,28 @@ module.exports ={
  skipIfReportDisabled,
  skipIfWorker,
 
-getlocalhostIPv6(){return'::1';},
+getenoughTestCPU(){
+constcpus=require('os').cpus();
+returnArray.isArray(cpus)&&(cpus.length>1||cpus[0].speed>999);
+},
+
+getenoughTestMeme(){
+returnrequire('os').totalmem()>0x70000000;/* 1.75 Gb */
+},
 
 gethasFipsCrypto(){
 returnhasCrypto&&require('crypto').getFips();
 },
 
+gethasIPv6(){
+constiFaces=require('os').networkInterfaces();
+constre=isWindows ? /LoopbackPseudo-Interface/ : /lo/;
+returnObject.keys(iFaces).some((name)=>{
+returnre.test(name)&&
+iFaces[name].some(({ family })=>family==='IPv6');
+});
+},
+
 getinFreeBSDJail(){
 if(inFreeBSDJail!==null)returninFreeBSDJail;
 
@@ -809,6 +803,17 @@ module.exports ={
 returninFreeBSDJail;
 },
 
+// On IBMi, process.platform and os.platform() both return 'aix',
+// It is not enough to differentiate between IBMi and real AIX system.
+getisIBMi(){
+returnrequire('os').type()==='OS400';
+},
+
+getisLinuxPPCBE(){
+return(process.platform==='linux')&&(process.arch==='ppc64')&&
+(require('os').endianness()==='BE');
+},
+
 getlocalhostIPv4(){
 if(localhostIPv4!==null)returnlocalhostIPv4;
 
@@ -830,6 +835,8 @@ module.exports ={
 returnlocalhostIPv4;
 },
 
+getlocalhostIPv6(){return'::1';},
+
 // opensslCli defined lazily to reduce overhead of spawnSync
 getopensslCli(){
 if(opensslCli!==null)returnopensslCli;