repl: copying tabs shouldn't trigger completion

PR-URL: #5958Fixes: #5954 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

Author: ghaiklor

doc/api/readline.md

@@ -357,10 +357,12 @@ a `'resize'` event on the `output` if/when the columns ever change
 
 Move cursor to the specified position in a given TTY stream.
 
-## readline.emitKeypressEvents(stream)
+## readline.emitKeypressEvents(stream[, interface])
 
 Causes `stream` to begin emitting `'keypress'` events corresponding to its
 input.
+Optionally, `interface` specifies a `readline.Interface` instance for which
+autocompletion is disabled when copy-pasted input is detected.
 
 Note that the stream, if it is a TTY, needs to be in raw mode:
 ```js

lib/readline.js

@@ -41,6 +41,7 @@ function Interface(input, output, completer, terminal){
 }
 
 this._sawReturn=false;
+this.isCompletionEnabled=true;
 
 EventEmitter.call(this);
 varhistorySize;
@@ -130,7 +131,7 @@ function Interface(input, output, completer, terminal){
 
 }else{
 
-emitKeypressEvents(input);
+emitKeypressEvents(input,this);
 
 // input usually refers to stdin
 input.on('keypress',onkeypress);
@@ -883,7 +884,7 @@ Interface.prototype._ttyWrite = function(s, key){
 
 case'tab':
 // If tab completion enabled, do that...
-if(typeofthis.completer==='function'){
+if(typeofthis.completer==='function'&&this.isCompletionEnabled){
 this._tabComplete();
 break;
 }
@@ -917,7 +918,7 @@ exports.Interface = Interface;
 constKEYPRESS_DECODER=Symbol('keypress-decoder');
 constESCAPE_DECODER=Symbol('escape-decoder');
 
-functionemitKeypressEvents(stream){
+functionemitKeypressEvents(stream,iface){
 if(stream[KEYPRESS_DECODER])return;
 varStringDecoder=require('string_decoder').StringDecoder;// lazy load
 stream[KEYPRESS_DECODER]=newStringDecoder('utf8');
@@ -930,6 +931,10 @@ function emitKeypressEvents(stream){
 varr=stream[KEYPRESS_DECODER].write(b);
 if(r){
 for(vari=0;i<r.length;i++){
+if(r[i]==='\t'&&typeofr[i+1]==='string'&&iface){
+iface.isCompletionEnabled=false;
+}
+
 try{
 stream[ESCAPE_DECODER].next(r[i]);
 }catch(err){
@@ -938,6 +943,10 @@ function emitKeypressEvents(stream){
 stream[ESCAPE_DECODER]=emitKeys(stream);
 stream[ESCAPE_DECODER].next();
 throwerr;
+}finally{
+if(iface){
+iface.isCompletionEnabled=true;
+}
 }
 }
 }

test/parallel/test-readline-interface.js

@@ -227,7 +227,9 @@ function isWarned(emitter){
 assert.strictEqual(called,false);
 called=true;
 });
-fi.emit('data','\tfo\to\t');
+for(varcharacterof'\tfo\to\t'){
+fi.emit('data',character);
+}
 fi.emit('data','\n');
 assert.ok(called);
 rli.close();