net: throw ERR_OUT_OF_RANGE if blockList.addSubnet prefix is NaN

Fixes: #36731 PR-URL: #36732 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: Lxxyx

lib/internal/blocklist.js

@@ -22,9 +22,10 @@ const{owner_symbol } = internalBinding('symbols');
 const{
 ERR_INVALID_ARG_TYPE,
 ERR_INVALID_ARG_VALUE,
-ERR_OUT_OF_RANGE,
 }=require('internal/errors').codes;
 
+const{ validateInt32 }=require('internal/validators');
+
 classBlockList{
 constructor(handle=newBlockListHandle()){
 // The handle argument is an intentionally undocumented
@@ -81,22 +82,18 @@ class BlockList{
 addSubnet(network,prefix,family='ipv4'){
 if(typeofnetwork!=='string')
 thrownewERR_INVALID_ARG_TYPE('network','string',network);
-if(typeofprefix!=='number')
-thrownewERR_INVALID_ARG_TYPE('prefix','number',prefix);
 if(typeoffamily!=='string')
 thrownewERR_INVALID_ARG_TYPE('family','string',family);
 family=family.toLowerCase();
 lettype;
 switch(family){
 case'ipv4':
 type=AF_INET;
-if(prefix<0||prefix>32)
-thrownewERR_OUT_OF_RANGE(prefix,'>= 0 and <= 32',prefix);
+validateInt32(prefix,'prefix',0,32);
 break;
 case'ipv6':
 type=AF_INET6;
-if(prefix<0||prefix>128)
-thrownewERR_OUT_OF_RANGE(prefix,'>= 0 and <= 128',prefix);
+validateInt32(prefix,'prefix',0,128);
 break;
 default:
 thrownewERR_INVALID_ARG_VALUE('family',family);

test/parallel/test-blocklist.js

@@ -150,6 +150,7 @@ const util = require('util');
 constblockList=newBlockList();
 assert.throws(()=>blockList.addSubnet(1),/ERR_INVALID_ARG_TYPE/);
 assert.throws(()=>blockList.addSubnet('',''),/ERR_INVALID_ARG_TYPE/);
+assert.throws(()=>blockList.addSubnet('',NaN),/ERR_OUT_OF_RANGE/);
 assert.throws(()=>blockList.addSubnet('',1,1),/ERR_INVALID_ARG_TYPE/);
 assert.throws(()=>blockList.addSubnet('',1,''),/ERR_INVALID_ARG_VALUE/);