url: reduce pathToFileURL cpp calls

PR-URL: #48709 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Stephen Belanger <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: anonrig

lib/internal/url.js

@@ -1496,25 +1496,27 @@ const backslashRegEx = /\\/g;
 constnewlineRegEx=/\n/g;
 constcarriageReturnRegEx=/\r/g;
 consttabRegEx=/\t/g;
+constquestionRegex=/\?/g;
+consthashRegex=/#/g;
 
 functionencodePathChars(filepath){
-if(StringPrototypeIncludes(filepath,'%'))
+if(StringPrototypeIndexOf(filepath,'%')!==-1)
 filepath=RegExpPrototypeSymbolReplace(percentRegEx,filepath,'%25');
 // In posix, backslash is a valid character in paths:
-if(!isWindows&&StringPrototypeIncludes(filepath,'\\'))
+if(!isWindows&&StringPrototypeIndexOf(filepath,'\\')!==-1)
 filepath=RegExpPrototypeSymbolReplace(backslashRegEx,filepath,'%5C');
-if(StringPrototypeIncludes(filepath,'\n'))
+if(StringPrototypeIndexOf(filepath,'\n')!==-1)
 filepath=RegExpPrototypeSymbolReplace(newlineRegEx,filepath,'%0A');
-if(StringPrototypeIncludes(filepath,'\r'))
+if(StringPrototypeIndexOf(filepath,'\r')!==-1)
 filepath=RegExpPrototypeSymbolReplace(carriageReturnRegEx,filepath,'%0D');
-if(StringPrototypeIncludes(filepath,'\t'))
+if(StringPrototypeIndexOf(filepath,'\t')!==-1)
 filepath=RegExpPrototypeSymbolReplace(tabRegEx,filepath,'%09');
 returnfilepath;
 }
 
 functionpathToFileURL(filepath){
-constoutURL=newURL('file://');
 if(isWindows&&StringPrototypeStartsWith(filepath,'\\\\')){
+constoutURL=newURL('file://');
 // UNC path format: \\server\share\resource
 consthostnameEndIndex=StringPrototypeIndexOf(filepath,'\\',2);
 if(hostnameEndIndex===-1){
@@ -1535,18 +1537,29 @@ function pathToFileURL(filepath){
 outURL.hostname=domainToASCII(hostname);
 outURL.pathname=encodePathChars(
 RegExpPrototypeSymbolReplace(backslashRegEx,StringPrototypeSlice(filepath,hostnameEndIndex),'/'));
-}else{
-letresolved=path.resolve(filepath);
-// path.resolve strips trailing slashes so we must add them back
-constfilePathLast=StringPrototypeCharCodeAt(filepath,
-filepath.length-1);
-if((filePathLast===CHAR_FORWARD_SLASH||
-(isWindows&&filePathLast===CHAR_BACKWARD_SLASH))&&
-resolved[resolved.length-1]!==path.sep)
-resolved+='/';
-outURL.pathname=encodePathChars(resolved);
+returnoutURL;
 }
-returnoutURL;
+letresolved=path.resolve(filepath);
+// path.resolve strips trailing slashes so we must add them back
+constfilePathLast=StringPrototypeCharCodeAt(filepath,
+filepath.length-1);
+if((filePathLast===CHAR_FORWARD_SLASH||
+(isWindows&&filePathLast===CHAR_BACKWARD_SLASH))&&
+resolved[resolved.length-1]!==path.sep)
+resolved+='/';
+
+// Call encodePathChars first to avoid encoding % again for ? and #.
+resolved=encodePathChars(resolved);
+
+// Question and hash character should be included in pathname.
+// Therefore, encoding is required to eliminate parsing them in different states.
+// This is done as an optimization to not creating a URL instance and
+// later triggering pathname setter, which impacts performance
+if(StringPrototypeIndexOf(resolved,'?')!==-1)
+resolved=RegExpPrototypeSymbolReplace(questionRegex,resolved,'%3F');
+if(StringPrototypeIndexOf(resolved,'#')!==-1)
+resolved=RegExpPrototypeSymbolReplace(hashRegex,resolved,'%23');
+returnnewURL(`file://${resolved}`);
 }
 
 functiontoPathIfFileURL(fileURLOrPath){