lib: make navigator not runtime-lookup process.version/arch/platform

Preserves most of #53649, except for `#language` due to the lack of Intl primordials.

Author: ljharb

lib/internal/bootstrap/node.js

@@ -85,6 +85,10 @@ const{
 },
 }=internalBinding('util');
 
+require('internal/process/arch');// Ensure the process arch is cached
+require('internal/process/platform');// Ensure the process platform is cached
+require('internal/process/version');// Etnsure the process version is cached
+
 setupProcessObject();
 
 setupGlobalProxy();

lib/internal/navigator.js

@@ -27,52 +27,53 @@ const{
 }=internalBinding('os');
 
 constkInitialize=Symbol('kInitialize');
-constnodeVersion=process.version;
+constnodeVersion=require('internal/process/version');
+constplatform=require('internal/process/platform');
+constarch=require('internal/process/arch');
 
 /**
- * @param{object} process
- * @param{string} process.platform
- * @param{string} process.arch
+ * @param{string} arch
+ * @param{string} platform
  * @returns{string}
  */
-functiongetNavigatorPlatform(process){
-if(process.platform==='darwin'){
+functiongetNavigatorPlatform(arch,platform){
+if(platform==='darwin'){
 // On macOS, modern browsers return 'MacIntel' even if running on Apple Silicon.
 return'MacIntel';
-}elseif(process.platform==='win32'){
+}elseif(platform==='win32'){
 // On Windows, modern browsers return 'Win32' even if running on a 64-bit version of Windows.
 // https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform#usage_notes
 return'Win32';
-}elseif(process.platform==='linux'){
-if(process.arch==='ia32'){
+}elseif(platform==='linux'){
+if(arch==='ia32'){
 return'Linux i686';
-}elseif(process.arch==='x64'){
+}elseif(arch==='x64'){
 return'Linux x86_64';
 }
-return`Linux ${process.arch}`;
-}elseif(process.platform==='freebsd'){
-if(process.arch==='ia32'){
+return`Linux ${arch}`;
+}elseif(platform==='freebsd'){
+if(arch==='ia32'){
 return'FreeBSD i386';
-}elseif(process.arch==='x64'){
+}elseif(arch==='x64'){
 return'FreeBSD amd64';
 }
-return`FreeBSD ${process.arch}`;
-}elseif(process.platform==='openbsd'){
-if(process.arch==='ia32'){
+return`FreeBSD ${arch}`;
+}elseif(platform==='openbsd'){
+if(arch==='ia32'){
 return'OpenBSD i386';
-}elseif(process.arch==='x64'){
+}elseif(arch==='x64'){
 return'OpenBSD amd64';
 }
-return`OpenBSD ${process.arch}`;
-}elseif(process.platform==='sunos'){
-if(process.arch==='ia32'){
+return`OpenBSD ${arch}`;
+}elseif(platform==='sunos'){
+if(arch==='ia32'){
 return'SunOS i86pc';
 }
-return`SunOS ${process.arch}`;
-}elseif(process.platform==='aix'){
+return`SunOS ${arch}`;
+}elseif(platform==='aix'){
 return'AIX';
 }
-return`${StringPrototypeToUpperCase(process.platform[0])}${StringPrototypeSlice(process.platform,1)}${process.arch}`;
+return`${StringPrototypeToUpperCase(platform[0])}${StringPrototypeSlice(platform,1)}${arch}`;
 }
 
 classNavigator{
@@ -126,7 +127,7 @@ class Navigator{
  * @return{string}
  */
 getplatform(){
-this.#platform ??=getNavigatorPlatform(process);
+this.#platform ??=getNavigatorPlatform(arch,platform);
 returnthis.#platform;
 }
 }

lib/internal/process/arch.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports=require('process').arch;

lib/internal/process/platform.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports=require('process').platform;

lib/internal/process/version.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports=require('process').version;

test/parallel/test-bootstrap-modules.js

@@ -58,28 +58,32 @@ expected.beforePreExec = new Set([
 'NativeModule internal/process/promises',
 'NativeModule internal/fixed_queue',
 'NativeModule async_hooks',
-'NativeModule internal/process/task_queues',
-'NativeModule timers',
+'Internal Binding blob',
+'Internal Binding mksnapshot',
+'Internal Binding performance',
+'Internal Binding permission',
 'Internal Binding trace_events',
+'Internal Binding url',
+'NativeModule internal/console/constructor',
+'NativeModule internal/console/global',
 'NativeModule internal/constants',
-'NativeModule path',
+'NativeModule internal/event_target',
+'NativeModule internal/perf/utils',
+'NativeModule internal/process/arch',
 'NativeModule internal/process/execution',
 'NativeModule internal/process/permission',
+'NativeModule internal/process/platform',
+'NativeModule internal/process/task_queues',
+'NativeModule internal/process/version',
 'NativeModule internal/process/warning',
-'NativeModule internal/console/constructor',
-'NativeModule internal/console/global',
 'NativeModule internal/querystring',
-'NativeModule querystring',
-'Internal Binding url',
-'Internal Binding blob',
 'NativeModule internal/url',
-'NativeModule util',
 'NativeModule internal/webidl',
-'Internal Binding performance',
-'Internal Binding permission',
-'NativeModule internal/perf/utils',
-'NativeModule internal/event_target',
-'Internal Binding mksnapshot',
+'NativeModule path',
+'NativeModule process',
+'NativeModule querystring',
+'NativeModule timers',
+'NativeModule util',
 'NativeModule internal/v8/startup_snapshot',
 'NativeModule internal/process/signal',
 'Internal Binding fs',

test/parallel/test-navigator.js

@@ -2,8 +2,36 @@
 
 'use strict';
 
-constcommon=require('../common');
+/* eslint node-core/require-common-first: 0 */
+
 constassert=require('assert');
+
+{
+
+// Ensures `navigator` has not been evaluated yet
+assert.strictEqual(require.resolve('../common')inrequire.cache,false);
+
+const{ version, platform, arch }=process;
+try{
+letcalled=false;
+Object.defineProperty(process,'arch',{get(){called+='arch|';returnarch;}});
+Object.defineProperty(process,'platform',{get(){called='platform|';returnplatform;}});
+Object.defineProperty(process,'version',{get(){called='version|';returnversion;}});
+
+navigator;// eslint-disable-line no-unused-expressions
+
+assert.strictEqual(
+called,
+false
+);
+}finally{
+Object.defineProperty(process,'arch',{value: arch});
+Object.defineProperty(process,'platform',{value: platform});
+Object.defineProperty(process,'version',{value: version});
+}
+}
+
+constcommon=require('../common');
 const{ getNavigatorPlatform }=require('internal/navigator');
 const{ execFile }=require('child_process');
 
@@ -57,23 +85,23 @@ if (process.platform === 'darwin'){
 assert.strictEqual(navigator.platform,`${process.platform[0].toUpperCase()}${process.platform.slice(1)}${process.arch}`);
 }
 
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'darwin'}),'MacIntel');
-assert.strictEqual(getNavigatorPlatform({arch: 'arm64',platform: 'darwin'}),'MacIntel');
-assert.strictEqual(getNavigatorPlatform({arch: 'ia32',platform: 'linux'}),'Linux i686');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'linux'}),'Linux x86_64');
-assert.strictEqual(getNavigatorPlatform({arch: 'arm64',platform: 'linux'}),'Linux arm64');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'win32'}),'Win32');
-assert.strictEqual(getNavigatorPlatform({arch: 'arm64',platform: 'win32'}),'Win32');
-assert.strictEqual(getNavigatorPlatform({arch: 'ia32',platform: 'freebsd'}),'FreeBSD i386');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'freebsd'}),'FreeBSD amd64');
-assert.strictEqual(getNavigatorPlatform({arch: 'arm64',platform: 'freebsd'}),'FreeBSD arm64');
-assert.strictEqual(getNavigatorPlatform({arch: 'ia32',platform: 'openbsd'}),'OpenBSD i386');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'openbsd'}),'OpenBSD amd64');
-assert.strictEqual(getNavigatorPlatform({arch: 'arm64',platform: 'openbsd'}),'OpenBSD arm64');
-assert.strictEqual(getNavigatorPlatform({arch: 'ia32',platform: 'sunos'}),'SunOS i86pc');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'sunos'}),'SunOS x64');
-assert.strictEqual(getNavigatorPlatform({arch: 'ppc',platform: 'aix'}),'AIX');
-assert.strictEqual(getNavigatorPlatform({arch: 'x64',platform: 'reactos'}),'Reactos x64');
+assert.strictEqual(getNavigatorPlatform('x64','darwin'),'MacIntel');
+assert.strictEqual(getNavigatorPlatform('arm64','darwin'),'MacIntel');
+assert.strictEqual(getNavigatorPlatform('ia32','linux'),'Linux i686');
+assert.strictEqual(getNavigatorPlatform('x64','linux'),'Linux x86_64');
+assert.strictEqual(getNavigatorPlatform('arm64','linux'),'Linux arm64');
+assert.strictEqual(getNavigatorPlatform('x64','win32'),'Win32');
+assert.strictEqual(getNavigatorPlatform('arm64','win32'),'Win32');
+assert.strictEqual(getNavigatorPlatform('ia32','freebsd'),'FreeBSD i386');
+assert.strictEqual(getNavigatorPlatform('x64','freebsd'),'FreeBSD amd64');
+assert.strictEqual(getNavigatorPlatform('arm64','freebsd'),'FreeBSD arm64');
+assert.strictEqual(getNavigatorPlatform('ia32','openbsd'),'OpenBSD i386');
+assert.strictEqual(getNavigatorPlatform('x64','openbsd'),'OpenBSD amd64');
+assert.strictEqual(getNavigatorPlatform('arm64','openbsd'),'OpenBSD arm64');
+assert.strictEqual(getNavigatorPlatform('ia32','sunos'),'SunOS i86pc');
+assert.strictEqual(getNavigatorPlatform('x64','sunos'),'SunOS x64');
+assert.strictEqual(getNavigatorPlatform('ppc','aix'),'AIX');
+assert.strictEqual(getNavigatorPlatform('x64','reactos'),'Reactos x64');
 
 assert.strictEqual(typeofnavigator.language,'string');
 assert.strictEqual(navigator.language.length!==0,true);