Skip to content

Commit 289f3dc

Browse files
Gioyikcodebytere
authored andcommitted
tools: replace deprecated iteritems() for items()
This is a Built-In change in Python 3 used by compile_commands_json.py to generate compile_commands_json.json. Node.js dropped Python 2 support in this script, `items()` works as expected replacement. PR-URL: #31528 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent 2973c1f commit 289f3dc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

‎tools/gyp/pylib/gyp/generator/compile_commands_json.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def CalculateVariables(default_variables, params):
4343

4444
defAddCommandsForTarget(cwd, target, params, per_config_commands):
4545
output_dir=params['generator_flags']['output_dir']
46-
forconfiguration_name, configurationintarget['configurations'].iteritems():
46+
forconfiguration_name, configurationintarget['configurations'].items():
4747
builddir_name=os.path.join(output_dir, configuration_name)
4848

4949
ifIsMac(params):
@@ -92,7 +92,7 @@ def resolve(filename):
9292

9393
defGenerateOutput(target_list, target_dicts, data, params):
9494
per_config_commands={}
95-
forqualified_target, targetintarget_dicts.iteritems():
95+
forqualified_target, targetintarget_dicts.items():
9696
build_file, target_name, toolset= (
9797
gyp.common.ParseQualifiedTarget(qualified_target))
9898
ifIsMac(params):
@@ -102,7 +102,7 @@ def GenerateOutput(target_list, target_dicts, data, params):
102102
AddCommandsForTarget(cwd, target, params, per_config_commands)
103103

104104
output_dir=params['generator_flags']['output_dir']
105-
forconfiguration_name, commandsinper_config_commands.iteritems():
105+
forconfiguration_name, commandsinper_config_commands.items():
106106
filename=os.path.join(output_dir,
107107
configuration_name,
108108
'compile_commands.json')

0 commit comments

Comments
(0)