child_process: rename _validateStdtio to getValidStdio

The name indicated only validation while it did much more and it returned a different value to the callee function. The underscore was also not necessary as the function is internal one way or the other. PR-URL: #26809 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: BridgeAR

lib/child_process.js

@@ -41,7 +41,7 @@ const{
 const{ validateString, isInt32 }=require('internal/validators');
 constchild_process=require('internal/child_process');
 const{
-_validateStdio,
+getValidStdio,
  setupChannel,
  ChildProcess
 }=child_process;
@@ -577,7 +577,7 @@ function spawnSync(file, args, options){
 // Validate and translate the kill signal, if present.
 options.killSignal=sanitizeKillSignal(options.killSignal);
 
-options.stdio=_validateStdio(options.stdio||'pipe',true).stdio;
+options.stdio=getValidStdio(options.stdio||'pipe',true).stdio;
 
 if(options.input){
 varstdin=options.stdio[0]={ ...options.stdio[0]};

lib/internal/child_process.js

@@ -315,7 +315,7 @@ ChildProcess.prototype.spawn = function(options){
 // If no `stdio` option was given - use default
 varstdio=options.stdio||'pipe';
 
-stdio=_validateStdio(stdio,false);
+stdio=getValidStdio(stdio,false);
 
 ipc=stdio.ipc;
 ipcFd=stdio.ipcFd;
@@ -873,7 +873,7 @@ function isInternal(message){
 
 functionnop(){}
 
-function_validateStdio(stdio,sync){
+functiongetValidStdio(stdio,sync){
 varipc;
 varipcFd;
 
@@ -1028,6 +1028,6 @@ function spawnSync(opts){
 module.exports={
  ChildProcess,
  setupChannel,
-_validateStdio,
+getValidStdio,
  spawnSync
 };

test/parallel/test-child-process-validate-stdio.js

@@ -3,21 +3,21 @@
 
 constcommon=require('../common');
 constassert=require('assert');
-const_validateStdio=require('internal/child_process')._validateStdio;
+constgetValidStdio=require('internal/child_process').getValidStdio;
 
 constexpectedError=
 common.expectsError({code: 'ERR_INVALID_OPT_VALUE',type: TypeError},2);
 
 // Should throw if string and not ignore, pipe, or inherit
-assert.throws(()=>_validateStdio('foo'),expectedError);
+assert.throws(()=>getValidStdio('foo'),expectedError);
 
 // Should throw if not a string or array
-assert.throws(()=>_validateStdio(600),expectedError);
+assert.throws(()=>getValidStdio(600),expectedError);
 
 // Should populate stdio with undefined if len < 3
 {
 conststdio1=[];
-constresult=_validateStdio(stdio1,false);
+constresult=getValidStdio(stdio1,false);
 assert.strictEqual(stdio1.length,3);
 assert.strictEqual(result.hasOwnProperty('stdio'),true);
 assert.strictEqual(result.hasOwnProperty('ipc'),true);
@@ -26,14 +26,14 @@ assert.throws(() => _validateStdio(600), expectedError);
 
 // Should throw if stdio has ipc and sync is true
 conststdio2=['ipc','ipc','ipc'];
-common.expectsError(()=>_validateStdio(stdio2,true),
+common.expectsError(()=>getValidStdio(stdio2,true),
 {code: 'ERR_IPC_SYNC_FORK',type: Error}
 );
 
 
 if(common.isMainThread){
 conststdio3=[process.stdin,process.stdout,process.stderr];
-constresult=_validateStdio(stdio3,false);
+constresult=getValidStdio(stdio3,false);
 assert.deepStrictEqual(result,{
 stdio: [
 {type: 'fd',fd: 0},