Skip to content

Commit 2973c1f

Browse files
dnlupcodebytere
authored andcommitted
benchmark: use let and const instead of var
Use let and const in domain, es, events, fixtures, fs, http, http2 and misc. PR-URL: #31518 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 22a37d6 commit 2973c1f

35 files changed

+105
-111
lines changed

‎benchmark/domain/domain-fn-args.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function main({n, args }){
1515
bench.start();
1616

1717
bdomain.enter();
18-
for(vari=0;i<n;i++){
18+
for(leti=0;i<n;i++){
1919
if(myArguments.length>=2){
2020
constargs=Array.prototype.slice.call(myArguments,1);
2121
fn.apply(this,args);

‎benchmark/es/defaultparams-bench.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ function defaultParams(x = 1, y = 2){
2222

2323
functionrunOldStyleDefaults(n){
2424
bench.start();
25-
for(vari=0;i<n;i++)
25+
for(leti=0;i<n;i++)
2626
oldStyleDefaults();
2727
bench.end(n);
2828
}
2929

3030
functionrunDefaultParams(n){
3131
bench.start();
32-
for(vari=0;i<n;i++)
32+
for(leti=0;i<n;i++)
3333
defaultParams();
3434
bench.end(n);
3535
}

‎benchmark/es/destructuring-bench.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ const bench = common.createBenchmark(main,{
99
});
1010

1111
functionrunSwapManual(n){
12-
varx,y,r;
12+
letx,y,r;
1313
bench.start();
14-
for(vari=0;i<n;i++){
14+
for(leti=0;i<n;i++){
1515
x=1,y=2;
1616
r=x;
1717
x=y;
@@ -23,9 +23,9 @@ function runSwapManual(n){
2323
}
2424

2525
functionrunSwapDestructured(n){
26-
varx,y;
26+
letx,y;
2727
bench.start();
28-
for(vari=0;i<n;i++){
28+
for(leti=0;i<n;i++){
2929
x=1,y=2;
3030
[x,y]=[y,x];
3131
assert.strictEqual(x,2);

‎benchmark/es/destructuring-object-bench.js‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@ const bench = common.createBenchmark(main,{
88
});
99

1010
functionrunNormal(n){
11-
vari=0;
1211
consto={x: 0,y: 1};
1312
bench.start();
14-
for(;i<n;i++){
13+
for(leti=0;i<n;i++){
1514
/* eslint-disable no-unused-vars */
1615
constx=o.x;
1716
consty=o.y;
@@ -22,10 +21,9 @@ function runNormal(n){
2221
}
2322

2423
functionrunDestructured(n){
25-
vari=0;
2624
consto={x: 0,y: 1};
2725
bench.start();
28-
for(;i<n;i++){
26+
for(leti=0;i<n;i++){
2927
/* eslint-disable no-unused-vars */
3028
const{ x, y, r =2}=o;
3129
/* eslint-enable no-unused-vars */

‎benchmark/es/foreach-bench.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ const bench = common.createBenchmark(main,{
1010

1111
functionuseFor(n,items,count){
1212
bench.start();
13-
for(vari=0;i<n;i++){
14-
for(varj=0;j<count;j++){
13+
for(leti=0;i<n;i++){
14+
for(letj=0;j<count;j++){
1515
// eslint-disable-next-line no-unused-vars
1616
constitem=items[j];
1717
}
@@ -21,7 +21,7 @@ function useFor(n, items, count){
2121

2222
functionuseForOf(n,items){
2323
bench.start();
24-
for(vari=0;i<n;i++){
24+
for(leti=0;i<n;i++){
2525
// eslint-disable-next-line no-unused-vars
2626
for(constitemofitems){}
2727
}
@@ -30,8 +30,8 @@ function useForOf(n, items){
3030

3131
functionuseForIn(n,items){
3232
bench.start();
33-
for(vari=0;i<n;i++){
34-
for(varjinitems){
33+
for(leti=0;i<n;i++){
34+
for(constjinitems){
3535
// eslint-disable-next-line no-unused-vars
3636
constitem=items[j];
3737
}
@@ -41,16 +41,16 @@ function useForIn(n, items){
4141

4242
functionuseForEach(n,items){
4343
bench.start();
44-
for(vari=0;i<n;i++){
44+
for(leti=0;i<n;i++){
4545
items.forEach((item)=>{});
4646
}
4747
bench.end(n);
4848
}
4949

5050
functionmain({ n, count, method }){
5151
constitems=newArray(count);
52-
varfn;
53-
for(vari=0;i<count;i++)
52+
letfn;
53+
for(leti=0;i<count;i++)
5454
items[i]=i;
5555

5656
switch(method){

‎benchmark/es/map-bench.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const bench = common.createBenchmark(main,{
1414
functionrunObject(n){
1515
constm={};
1616
bench.start();
17-
for(vari=0;i<n;i++){
17+
for(leti=0;i<n;i++){
1818
m[`i${i}`]=i;
1919
m[`s${i}`]=String(i);
2020
assert.strictEqual(String(m[`i${i}`]),m[`s${i}`]);
@@ -27,7 +27,7 @@ function runObject(n){
2727
functionrunNullProtoObject(n){
2828
constm=Object.create(null);
2929
bench.start();
30-
for(vari=0;i<n;i++){
30+
for(leti=0;i<n;i++){
3131
m[`i${i}`]=i;
3232
m[`s${i}`]=String(i);
3333
assert.strictEqual(String(m[`i${i}`]),m[`s${i}`]);
@@ -40,7 +40,7 @@ function runNullProtoObject(n){
4040
functionrunNullProtoLiteralObject(n){
4141
constm={__proto__: null};
4242
bench.start();
43-
for(vari=0;i<n;i++){
43+
for(leti=0;i<n;i++){
4444
m[`i${i}`]=i;
4545
m[`s${i}`]=String(i);
4646
assert.strictEqual(String(m[`i${i}`]),m[`s${i}`]);
@@ -56,7 +56,7 @@ StorageObject.prototype = Object.create(null);
5656
functionrunStorageObject(n){
5757
constm=newStorageObject();
5858
bench.start();
59-
for(vari=0;i<n;i++){
59+
for(leti=0;i<n;i++){
6060
m[`i${i}`]=i;
6161
m[`s${i}`]=String(i);
6262
assert.strictEqual(String(m[`i${i}`]),m[`s${i}`]);
@@ -79,7 +79,7 @@ function fakeMap(){
7979
functionrunFakeMap(n){
8080
constm=fakeMap();
8181
bench.start();
82-
for(vari=0;i<n;i++){
82+
for(leti=0;i<n;i++){
8383
m.set(`i${i}`,i);
8484
m.set(`s${i}`,String(i));
8585
assert.strictEqual(String(m.get(`i${i}`)),m.get(`s${i}`));
@@ -92,7 +92,7 @@ function runFakeMap(n){
9292
functionrunMap(n){
9393
constm=newMap();
9494
bench.start();
95-
for(vari=0;i<n;i++){
95+
for(leti=0;i<n;i++){
9696
m.set(`i${i}`,i);
9797
m.set(`s${i}`,String(i));
9898
assert.strictEqual(String(m.get(`i${i}`)),m.get(`s${i}`));

‎benchmark/es/restparams-bench.js‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const bench = common.createBenchmark(main,{
1111
functioncopyArguments(){
1212
constlen=arguments.length;
1313
constargs=newArray(len);
14-
for(vari=0;i<len;i++)
14+
for(leti=0;i<len;i++)
1515
args[i]=arguments[i];
1616
assert.strictEqual(args[0],1);
1717
assert.strictEqual(args[1],2);
@@ -34,22 +34,22 @@ function useArguments(){
3434
}
3535

3636
functionrunCopyArguments(n){
37-
for(vari=0;i<n;i++)
37+
for(leti=0;i<n;i++)
3838
copyArguments(1,2,'a','b');
3939
}
4040

4141
functionrunRestArguments(n){
42-
for(vari=0;i<n;i++)
42+
for(leti=0;i<n;i++)
4343
restArguments(1,2,'a','b');
4444
}
4545

4646
functionrunUseArguments(n){
47-
for(vari=0;i<n;i++)
47+
for(leti=0;i<n;i++)
4848
useArguments(1,2,'a','b');
4949
}
5050

5151
functionmain({ n, method }){
52-
varfn;
52+
letfn;
5353
switch(method){
5454
case'':
5555
// Empty string falls through to next line as default, mostly for tests.

‎benchmark/es/spread-assign.js‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,25 @@ function main({n, context, count, rest, method }){
1616
src[`p${n}`]=n;
1717

1818
letobj;// eslint-disable-line no-unused-vars
19-
leti;
2019

2120
switch(method){
2221
case'':
2322
// Empty string falls through to next line as default, mostly for tests.
2423
case'_extend':
2524
bench.start();
26-
for(i=0;i<n;i++)
25+
for(leti=0;i<n;i++)
2726
obj=util._extend({},src);
2827
bench.end(n);
2928
break;
3029
case'assign':
3130
bench.start();
32-
for(i=0;i<n;i++)
31+
for(leti=0;i<n;i++)
3332
obj=Object.assign({},src);
3433
bench.end(n);
3534
break;
3635
case'spread':
3736
bench.start();
38-
for(i=0;i<n;i++)
37+
for(leti=0;i<n;i++)
3938
obj={ ...src};
4039
bench.end(n);
4140
break;

‎benchmark/es/spread-bench.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,32 +25,32 @@ function makeTest(count, rest){
2525

2626
functionmain({ n, context, count, rest, method }){
2727
constctx=context==='context' ? {} : null;
28-
varfn=makeTest(count,rest);
28+
letfn=makeTest(count,rest);
2929
constargs=newArray(count);
30-
vari;
31-
for(i=0;i<count;i++)
30+
31+
for(leti=0;i<count;i++)
3232
args[i]=i;
3333

3434
switch(method){
3535
case'':
3636
// Empty string falls through to next line as default, mostly for tests.
3737
case'apply':
3838
bench.start();
39-
for(i=0;i<n;i++)
39+
for(leti=0;i<n;i++)
4040
fn.apply(ctx,args);
4141
bench.end(n);
4242
break;
4343
case'spread':
4444
if(ctx!==null)
4545
fn=fn.bind(ctx);
4646
bench.start();
47-
for(i=0;i<n;i++)
47+
for(leti=0;i<n;i++)
4848
fn(...args);
4949
bench.end(n);
5050
break;
5151
case'call-spread':
5252
bench.start();
53-
for(i=0;i<n;i++)
53+
for(leti=0;i<n;i++)
5454
fn.call(ctx, ...args);
5555
bench.end(n);
5656
break;

‎benchmark/events/ee-add-remove.js‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,16 @@ function main({n }){
88
constee=newevents.EventEmitter();
99
constlisteners=[];
1010

11-
vark;
12-
for(k=0;k<10;k+=1)
11+
for(letk=0;k<10;k+=1)
1312
listeners.push(()=>{});
1413

1514
bench.start();
16-
for(vari=0;i<n;i+=1){
15+
for(leti=0;i<n;i+=1){
1716
constdummy=(i%2===0) ? 'dummy0' : 'dummy1';
18-
for(k=listeners.length;--k>=0;/* empty */){
17+
for(letk=listeners.length;--k>=0;/* empty */){
1918
ee.on(dummy,listeners[k]);
2019
}
21-
for(k=listeners.length;--k>=0;/* empty */){
20+
for(letk=listeners.length;--k>=0;/* empty */){
2221
ee.removeListener(dummy,listeners[k]);
2322
}
2423
}

0 commit comments

Comments
(0)