module: correctly detect top-level await in ambiguous contexts

Fixes: #58331 PR-URL: #58646 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>

Author: islandryu

src/node_contextify.cc

@@ -1446,6 +1446,12 @@ static std::vector<std::string_view> throws_only_in_cjs_error_messages ={
 "await is only valid in async functions and "
 "the top level bodies of modules"};
 
+staticconstauto maybe_top_level_await_errors =
+ std::array<std::string_view, 2>{
+"missing ) after argument list", // example: `func(await 1);`
+"SyntaxError: Unexpected"// example: `if(await 1)`
+ };
+
 // If cached_data is provided, it would be used for the compilation and
 // the on-disk compilation cache from NODE_COMPILE_CACHE (if configured)
 // would be ignored.
@@ -1654,6 +1660,16 @@ bool ShouldRetryAsESM(Realm* realm,
 break;
  }
  }
+
+for (constauto& error_message : maybe_top_level_await_errors){
+if (message_view.find(error_message) != std::string_view::npos){
+// If the error message is related to top-level await, we can try to
+// compile it as ESM.
+ maybe_valid_in_esm = true;
+break;
+ }
+ }
+
 if (!maybe_valid_in_esm){
 returnfalse;
  }

test/es-module/test-esm-tla-syntax-errors-not-recognized-as-tla-error.mjs

@@ -0,0 +1,78 @@
+import{spawnPromisified}from'../common/index.mjs';
+import{describe,it}from'node:test';
+import{strictEqual,match}from'node:assert';
+
+describe('unusual top-level await syntax errors',()=>{
+constexpressions=[
+// string
+{expression: '""'},
+// number
+{expression: '0'},
+// boolean
+{expression: 'true'},
+// null
+{expression: 'null'},
+// undefined
+{expression: 'undefined'},
+// object
+{expression: '{}'},
+// array
+{expression: '[]'},
+// new
+{expression: 'new Date()'},
+// identifier
+{initialize: 'const a = 2;',expression: 'a'},
+];
+it('should not crash the process',async()=>{
+for(const{ expression, initialize }ofexpressions){
+constwrapperExpressions=[
+`function callAwait(){}; callAwait(await ${expression});`,
+`if (await ${expression}){}`,
+`{key: await ${expression} }`,
+`[await ${expression}]`,
+`(await ${expression})`,
+];
+for(constwrapperExpressionofwrapperExpressions){
+const{ code, signal, stdout, stderr }=awaitspawnPromisified(process.execPath,[
+'--eval',
+`
+${initialize||''}
+${wrapperExpression}
+ `,
+]);
+
+strictEqual(stderr,'');
+strictEqual(stdout,'');
+strictEqual(code,0);
+strictEqual(signal,null);
+}
+}
+});
+
+it('should throw the error for unrelated syntax errors',async()=>{
+constexpression='foo bar';
+constwrapperExpressions=[
+[`function callSyntaxError(){}; callSyntaxError(${expression});`,/missing\)afterargumentlist/],
+[`if (${expression}){}`,/Unexpectedidentifier/],
+[`{key: ${expression} }`,/Unexpectedidentifier/],
+[`[${expression}]`,/Unexpectedidentifier/],
+[`(${expression})`,/Unexpectedidentifier/],
+[`const ${expression} = 1;`,/Missinginitializerinconstdeclaration/],
+['console.log(\'PI: \' Math.PI);',/missing\)afterargumentlist/],
+['callAwait(await "" "");',/missing\)afterargumentlist/],
+];
+
+for(const[wrapperExpression,error]ofwrapperExpressions){
+const{ code, signal, stdout, stderr }=awaitspawnPromisified(process.execPath,[
+'--eval',
+`
+${wrapperExpression}
+ `,
+]);
+match(stderr,error);
+strictEqual(stdout,'');
+strictEqual(code,1);
+strictEqual(signal,null);
+}
+});
+});