tools: add lint rule to ensure assertions are reached

PR-URL: #60125 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Author: aduh95

test/eslint.config_partial.mjs

@@ -153,6 +153,14 @@ export default [
 ],
 },
 },
+{
+files: [
+'test/{message,module-hooks,node-api,pummel,pseudo-tty,v8-updates,wasi}/**/*.{js,mjs,cjs}',
+],
+rules: {
+'node-core/must-call-assert': 'error',
+},
+},
 {
 files: [
 'test/{common,fixtures,wpt}/**/*.{js,mjs,cjs}',

test/message/assert_throws_stack.js

@@ -1,6 +1,6 @@
 'use strict';
 
 require('../common');
-constassert=require('assert').strict;
+constassert=require('assert/strict');
 
 assert.throws(()=>{thrownewError('foo');},{bar: true});

test/message/node_run_non_existent.js

@@ -1,7 +1,7 @@
 'use strict';
 
 require('../common');
-constassert=require('node:assert').strict;
+constassert=require('node:assert/strict');
 constchildProcess=require('node:child_process');
 constfixtures=require('../common/fixtures');
 

test/module-hooks/test-module-hooks-import-wasm.mjs

@@ -1,13 +1,13 @@
 // This tests that module.registerHooks() can be used to support unknown formats, like
 // import(wasm)
-import'../common/index.mjs';
+import{mustCall}from'../common/index.mjs';
 
 importassertfrom'node:assert';
 import{registerHooks,createRequire}from'node:module';
 import{readFileSync}from'node:fs';
 
 registerHooks({
-load(url,context,nextLoad){
+load: mustCall((url,context,nextLoad)=>{
 assert.match(url,/simple\.wasm$/);
 constsource=
 `const buf = Buffer.from([${Array.from(readFileSync(newURL(url))).join(',')}]);
@@ -21,7 +21,7 @@ registerHooks({
  source,
 format: 'module',
 };
-},
+}),
 });
 
 // Checks that it works with require.

test/module-hooks/test-module-hooks-load-buffers.js

@@ -1,6 +1,6 @@
 'use strict';
 
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 const{ registerHooks }=require('module');
 
@@ -15,15 +15,7 @@ const hook1 = registerHooks({
 resolve(specifier,context,nextResolve){
 return{shortCircuit: true,url: `test://${specifier}`};
 },
-load(url,context,nextLoad){
-constresult=nextLoad(url,context);
-if(url==='test://array_buffer'){
-assert.deepStrictEqual(result.source,encoder.encode(arrayBufferSource).buffer);
-}elseif(url==='test://array_buffer_view'){
-assert.deepStrictEqual(result.source,encoder.encode(arrayBufferViewSource));
-}
-returnresult;
-},
+load: common.mustNotCall(),
 });
 
 consthook2=registerHooks({

test/module-hooks/test-module-hooks-load-chained.js

@@ -1,30 +1,30 @@
 'use strict';
 
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 const{ registerHooks }=require('module');
 
 // Test that multiple loaders works together.
 consthook1=registerHooks({
-load(url,context,nextLoad){
+load: common.mustCall((url,context,nextLoad)=>{
 constresult=nextLoad(url,context);
 assert.strictEqual(result.source,'');
 return{
 source: 'exports.hello = "world"',
 format: 'commonjs',
 };
-},
+}),
 });
 
 consthook2=registerHooks({
-load(url,context,nextLoad){
+load: common.mustCall((url,context,nextLoad)=>{
 constresult=nextLoad(url,context);
 assert.strictEqual(result.source,'exports.hello = "world"');
 return{
 source: 'export const hello = "world"',
 format: 'module',
 };
-},
+}),
 });
 
 constmod=require('../fixtures/empty.js');

test/module-hooks/test-module-hooks-load-detection.js

@@ -1,18 +1,18 @@
 'use strict';
 
-require('../common');
+constcommon=require('../common');
 constassert=require('assert');
 const{ registerHooks }=require('module');
 
 // Test that module syntax detection works.
 consthook=registerHooks({
-load(url,context,nextLoad){
+load: common.mustCall((url,context,nextLoad)=>{
 constresult=nextLoad(url,context);
 assert.strictEqual(result.source,'');
 return{
 source: 'export const hello = "world"',
 };
-},
+}),
 });
 
 constmod=require('../fixtures/empty.js');

test/module-hooks/test-module-hooks-load-url-change-import.mjs

@@ -7,13 +7,13 @@ import{fileURL } from '../common/fixtures.mjs'
 // It changes `foo` package name into `redirected-fs` and then loads `redirected-fs`
 
 consthook=registerHooks({
-resolve(specifier,context,nextResolve){
+resolve: mustCall((specifier,context,nextResolve)=>{
 assert.strictEqual(specifier,'foo');
 return{
 url: 'foo://bar',
 shortCircuit: true,
 };
-},
+}),
 load: mustCall(functionload(url,context,nextLoad){
 assert.strictEqual(url,'foo://bar');
 returnnextLoad(fileURL('module-hooks','redirected-fs.js').href,context);

test/module-hooks/test-module-hooks-load-url-change-require.js

@@ -9,13 +9,13 @@ const fixtures = require('../common/fixtures');
 // It changes `foo` package name into `redirected-fs` and then loads `redirected-fs`
 
 consthook=registerHooks({
-resolve(specifier,context,nextResolve){
+resolve: common.mustCall((specifier,context,nextResolve)=>{
 assert.strictEqual(specifier,'foo');
 return{
 url: 'foo://bar',
 shortCircuit: true,
 };
-},
+}),
 load: common.mustCall(functionload(url,context,nextLoad){
 assert.strictEqual(url,'foo://bar');
 returnnextLoad(

test/module-hooks/test-module-hooks-require-wasm.js

@@ -9,7 +9,7 @@ const{registerHooks } = require('module');
 const{ readFileSync }=require('fs');
 
 registerHooks({
-load(url,context,nextLoad){
+load: common.mustCall((url,context,nextLoad)=>{
 assert.match(url,/simple\.wasm$/);
 constsource=
 `const buf = Buffer.from([${Array.from(readFileSync(newURL(url))).join(',')}]);
@@ -20,7 +20,7 @@ registerHooks({
  source,
 format: 'commonjs',
 };
-},
+},2),
 });
 
 // Checks that it works with require.