test: Update to const and use regex for assertions

Intregrisist · addaleax · commit 2a8d29339d5c · 2016-12-05T03:35:38.000+01:00
Use const over var. Assert error message with regex. PR-URL: #9891 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-net-localerror.js b/test/parallel/test-net-localerror.js
@@ -1,19 +1,19 @@
 'use strict';
-var common = require('../common');
-var assert = require('assert');
-var net = require('net');
+const common = require('../common');
+const assert = require('assert');
+const net = require('net');
 
 connect({
 host: 'localhost',
 port: common.PORT,
 localPort: 'foobar',
-}, 'localPort should be a number: foobar');
+}, /^TypeError: "localPort" option should be a number: foobar$/);
 
 connect({
 host: 'localhost',
 port: common.PORT,
 localAddress: 'foobar',
-}, 'localAddress should be a valid IP: foobar');
+}, /^TypeError: "localAddress" option must be a valid IP: foobar$/);
 
 function connect(opts, msg){
 assert.throws(function(){

-Original file line number
+Diff line change
@@ @@ -1,19 +1,19 @@ @@
 'use strict';
 -varcommon=require('../common');
 -varassert=require('assert');
 -varnet=require('net');
 +constcommon=require('../common');
 +constassert=require('assert');
 +constnet=require('net');
 connect({
 host: 'localhost',
 port: common.PORT,
 localPort: 'foobar',
 -},'localPortshould be a number: foobar');
 +},/^TypeError:"localPort"optionshouldbeanumber:foobar$/);
 connect({
 host: 'localhost',
 port: common.PORT,
 localAddress: 'foobar',
 -},'localAddress should be a valid IP: foobar');
 +},/^TypeError:"localAddress"optionmustbeavalidIP:foobar$/);
 functionconnect(opts,msg){
 assert.throws(function(){