test: refactor make-callback-recurse test

Move copy/pasted callback into its own function. PR-URL: #9498 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>

Author: Trott

test/addons/make-callback-recurse/test.js

@@ -132,38 +132,20 @@ function checkDomains(){
 }));
 }),1);
 
-// Make sure nextTick, setImmediate and setTimeout can all recover properly
-// after a thrown makeCallback call.
-process.nextTick(common.mustCall(function(){
+functiontestTimer(id){
+// Make sure nextTick, setImmediate and setTimeout can all recover properly
+// after a thrown makeCallback call.
 constd=domain.create();
 d.on('error',common.mustCall(function(e){
-assert.strictEqual(e.message,'throw from domain 3');
+assert.strictEqual(e.message,`throw from domain ${id}`);
 }));
 makeCallback({domain: d},function(){
-thrownewError('throw from domain 3');
+thrownewError(`throw from domain ${id}`);
 });
 thrownewError('UNREACHABLE');
-}));
+}
 
-setImmediate(common.mustCall(function(){
-constd=domain.create();
-d.on('error',common.mustCall(function(e){
-assert.strictEqual(e.message,'throw from domain 2');
-}));
-makeCallback({domain: d},function(){
-thrownewError('throw from domain 2');
-});
-thrownewError('UNREACHABLE');
-}));
-
-setTimeout(common.mustCall(function(){
-constd=domain.create();
-d.on('error',common.mustCall(function(e){
-assert.strictEqual(e.message,'throw from domain 1');
-}));
-makeCallback({domain: d},function(){
-thrownewError('throw from domain 1');
-});
-thrownewError('UNREACHABLE');
-}));
+process.nextTick(common.mustCall(testTimer),3);
+setImmediate(common.mustCall(testTimer),2);
+setTimeout(common.mustCall(testTimer),1,1);
 }