test: improve the code in test-pipe.js

* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove console.log and process.stdout.write PR-URL: #10452 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Brian White <[email protected]>

Author: edsadr

test/sequential/test-pipe.js

@@ -1,111 +1,97 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
-varhttp=require('http');
-varnet=require('net');
+constcommon=require('../common');
+constassert=require('assert');
+consthttp=require('http');
+constnet=require('net');
 
-varwebPort=common.PORT;
-vartcpPort=webPort+1;
+constwebPort=common.PORT;
+consttcpPort=webPort+1;
+constbufferSize=5*1024*1024;
 
-varlistenCount=0;
-vargotThanks=false;
-vartcpLengthSeen=0;
-varbufferSize=5*1024*1024;
+letlistenCount=0;
+letgotThanks=false;
+lettcpLengthSeen=0;
 
 
 /*
  * 5MB of random buffer.
  */
-varbuffer=Buffer(bufferSize);
-for(vari=0;i<buffer.length;i++){
+constbuffer=Buffer.allocUnsafe(bufferSize);
+for(leti=0;i<buffer.length;i++){
 buffer[i]=parseInt(Math.random()*10000)%256;
 }
 
 
-varweb=http.Server(function(req,res){
+constweb=http.Server(common.mustCall((req,res)=>{
 web.close();
 
-console.log(req.headers);
-
-varsocket=net.Stream();
+constsocket=net.Stream();
 socket.connect(tcpPort);
 
-socket.on('connect',function(){
-console.log('socket connected');
-});
+socket.on('connect',common.mustCall(()=>{}));
 
 req.pipe(socket);
 
-req.on('end',function(){
+req.on('end',common.mustCall(()=>{
 res.writeHead(200);
 res.write('thanks');
 res.end();
-console.log('response with \'thanks\'');
-});
+}));
 
-req.connection.on('error',function(e){
-console.log('http server-side error: '+e.message);
-process.exit(1);
+req.connection.on('error',(e)=>{
+assert.ifError(e);
 });
-});
+}));
+
 web.listen(webPort,startClient);
 
 
-vartcp=net.Server(function(s){
+consttcp=net.Server(common.mustCall((s)=>{
 tcp.close();
 
-console.log('tcp server connection');
-
-vari=0;
+leti=0;
 
-s.on('data',function(d){
-process.stdout.write('.');
+s.on('data',(d)=>{
 tcpLengthSeen+=d.length;
-for(varj=0;j<d.length;j++){
-assert.equal(buffer[i],d[j]);
+for(letj=0;j<d.length;j++){
+assert.strictEqual(buffer[i],d[j]);
 i++;
 }
 });
 
-s.on('end',function(){
-console.log('tcp socket disconnect');
+s.on('end',common.mustCall(()=>{
 s.end();
-});
+}));
 
-s.on('error',function(e){
-console.log('tcp server-side error: '+e.message);
-process.exit(1);
+s.on('error',(e)=>{
+assert.ifError(e);
 });
-});
-tcp.listen(tcpPort,startClient);
+}));
 
+tcp.listen(tcpPort,startClient);
 
 functionstartClient(){
 listenCount++;
 if(listenCount<2)return;
 
-console.log('Making request');
-
-varreq=http.request({
+constreq=http.request({
 port: common.PORT,
 method: 'GET',
 path: '/',
 headers: {'content-length': buffer.length}
-},function(res){
-console.log('Got response');
+},common.mustCall((res)=>{
 res.setEncoding('utf8');
-res.on('data',function(string){
-assert.equal('thanks',string);
+res.on('data',common.mustCall((string)=>{
+assert.strictEqual('thanks',string);
 gotThanks=true;
-});
-});
+}));
+}));
 req.write(buffer);
 req.end();
-console.error('ended request',req);
 }
 
-process.on('exit',function(){
+process.on('exit',()=>{
 assert.ok(gotThanks);
-assert.equal(bufferSize,tcpLengthSeen);
+assert.strictEqual(bufferSize,tcpLengthSeen);
 });