lib: reduce url getters on makeRequireFunction

PR-URL: #48492 Refs: nodejs/performance#92 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: anonrig

lib/internal/modules/helpers.js

@@ -86,20 +86,18 @@ function makeRequireFunction(mod, redirects){
 if(destination===true){
 missing=false;
 }elseif(destination){
-consthref=destination.href;
-if(destination.protocol==='node:'){
+const{href, protocol }=destination;
+if(protocol==='node:'){
 constspecifier=destination.pathname;
 
 if(BuiltinModule.canBeRequiredByUsers(specifier)){
 constmod=loadBuiltinModule(specifier,href);
 returnmod.exports;
 }
 thrownewERR_UNKNOWN_BUILTIN_MODULE(specifier);
-}elseif(destination.protocol==='file:'){
-letfilepath;
-if(urlToFileCache.has(href)){
-filepath=urlToFileCache.get(href);
-}else{
+}elseif(protocol==='file:'){
+letfilepath=urlToFileCache.get(href);
+if(!filepath){
 filepath=fileURLToPath(destination);
 urlToFileCache.set(href,filepath);
 }