buffer: improve Buffer.equals performance

kylo5aby · UlisesGascon · commit 32d65c001d6d · 2023-12-11T17:50:24.000Z
PR-URL: #50621 Refs: #50620 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -860,11 +860,11 @@ Buffer.prototype.equals = function equals(otherBuffer){
 
 if (this === otherBuffer)
 return true;
-
- if (this.byteLength !== otherBuffer.byteLength)
+ const len = TypedArrayPrototypeGetByteLength(this);
+ if (len !== TypedArrayPrototypeGetByteLength(otherBuffer))
 return false;
 
- return this.byteLength === 0 || _compare(this, otherBuffer) === 0;
+ return len === 0 || _compare(this, otherBuffer) === 0;
 };
 
 let INSPECT_MAX_BYTES = 50;

-Original file line number
+Diff line change
 if(this===otherBuffer)
 returntrue;
+-
 -if(this.byteLength!==otherBuffer.byteLength)
 +constlen=TypedArrayPrototypeGetByteLength(this);
 +if(len!==TypedArrayPrototypeGetByteLength(otherBuffer))
 returnfalse;
 -returnthis.byteLength===0||_compare(this,otherBuffer)===0;
 +returnlen===0||_compare(this,otherBuffer)===0;
 };
 letINSPECT_MAX_BYTES=50;