src: disable uncaught exception abortion for ESM syntax detection

PR-URL: #50987 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

Author: anonrig

src/node_contextify.cc

@@ -1469,6 +1469,7 @@ void ContextifyContext::ContainsModuleSyntax(
 String::NewFromUtf8(isolate, "__dirname").ToLocalChecked()};
 
  TryCatchScope try_catch(env);
+ ShouldNotAbortOnUncaughtScope no_abort_scope(env);
 
 ContextifyContext::CompileFunctionAndCacheResult(env,
  context,

test/es-module/test-esm-detect-ambiguous.mjs

@@ -235,3 +235,23 @@ describe('--experimental-detect-module',{concurrency: true }, () =>{
 }
 });
 });
+
+// Validate temporarily disabling `--abort-on-uncaught-exception`
+// while running `containsModuleSyntax`.
+// Ref: https://github.com/nodejs/node/issues/50878
+describe('Wrapping a `require` of an ES module while using `--abort-on-uncaught-exception`',()=>{
+it('should work',async()=>{
+const{ code, signal, stdout, stderr }=awaitspawnPromisified(process.execPath,[
+'--abort-on-uncaught-exception',
+'--eval',
+'assert.throws(() => require("./package-type-module/esm.js"),{code: "ERR_REQUIRE_ESM"})',
+],{
+cwd: fixtures.path('es-modules'),
+});
+
+strictEqual(stderr,'');
+strictEqual(stdout,'');
+strictEqual(code,0);
+strictEqual(signal,null);
+});
+});