test: refactor http pipelined socket test

In test-http-incoming-pipelined-socket-destory: * setTimeout() with no duration -> setImmediate() * eliminate unneeded exit listener * use common.mustCall() * var -> const/let PR-URL: #10189 Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>

Author: Trott

test/parallel/test-http-incoming-pipelined-socket-destroy.js

@@ -1,16 +1,17 @@
 'use strict';
-require('../common');
+constcommon=require('../common');
 
-varhttp=require('http');
-varnet=require('net');
+consthttp=require('http');
+constnet=require('net');
 
+constseeds=[3,1,2,3,4,1,2,3,4,1,2,3,4];
 
 // Set up some timing issues where sockets can be destroyed
 // via either the req or res.
-varserver=http.createServer(function(req,res){
+constserver=http.createServer(common.mustCall(function(req,res){
 switch(req.url){
 case'/1':
-returnsetTimeout(function(){
+returnsetImmediate(function(){
 req.socket.destroy();
 server.emit('requestDone');
 });
@@ -24,7 +25,7 @@ var server = http.createServer(function(req, res){
 // in one case, actually send a response in 2 chunks
 case'/3':
 res.write('hello ');
-returnsetTimeout(function(){
+returnsetImmediate(function(){
 res.end('world!');
 server.emit('requestDone');
 });
@@ -33,7 +34,7 @@ var server = http.createServer(function(req, res){
 res.destroy();
 server.emit('requestDone');
 }
-});
+},seeds.length));
 
 
 // Make a bunch of requests pipelined on the same socket
@@ -47,10 +48,9 @@ function generator(seeds){
 }
 
 
-server.listen(0,function(){
-varseeds=[3,1,2,3,4,1,2,3,4,1,2,3,4];
-varclient=net.connect({port: this.address().port});
-vardone=0;
+server.listen(0,common.mustCall(function(){
+constclient=net.connect({port: this.address().port});
+letdone=0;
 server.on('requestDone',function(){
 if(++done===seeds.length){
 server.close();
@@ -60,9 +60,4 @@ server.listen(0, function(){
 // immediately write the pipelined requests.
 // Some of these will not have a socket to destroy!
 client.write(generator(seeds));
-});
-
-process.on('exit',function(c){
-if(!c)
-console.log('ok');
-});
+}));