build, tools, win: add .S files support to GYP

bzoz · targos · commit 383d8092b1fa · 2018-11-29T15:40:07.000+01:00
Makes GYP properly handle .S files. Fixes: nodejs/node-v8#89 PR-URL: #24553 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/tools/gyp/pylib/gyp/generator/msvs.py b/tools/gyp/pylib/gyp/generator/msvs.py
@@ -2156,6 +2156,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
 A pair of (group this file should be part of, the label of element)
 """
 _, ext = os.path.splitext(source)
+ ext = ext.lower()
 if ext in extension_to_rule_name:
 group = 'rule'
 element = extension_to_rule_name[ext]
@@ -2168,7 +2169,7 @@ def _MapFileToMsBuildSourceType(source, rule_dependencies,
 elif ext == '.rc':
 group = 'resource'
 element = 'ResourceCompile'
- elif ext == '.asm':
+ elif ext in ['.s', '.asm']:
 group = 'masm'
 element = 'MASM'
 elif ext == '.idl':

-Original file line number
+Diff line change
  A pair of (group this file should be part of, the label of element)
  """
 _, ext=os.path.splitext(source)
 +ext=ext.lower()
 ifextinextension_to_rule_name:
 group='rule'
 element=extension_to_rule_name[ext]
 elifext=='.rc':
 group='resource'
 element='ResourceCompile'
 -elifext=='.asm':
 +elifextin ['.s', '.asm']:
 group='masm'
 element='MASM'
 elifext=='.idl':