test: use dynamic port in 3 test-cluster-worker tests

Sebastian Plesciuc · MylesBorins · commit 384fa17ffacf · 2017-05-17T21:32:10.000-04:00
Remove common.PORT from test-cluster-worker-disconnect, test-cluster-worker-exit and test-cluster-worker-kill to eliminate the possibility that a dynamic port used in another test will collide with common.PORT. PR-URL: #12443 Ref: #12376 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-cluster-worker-disconnect.js b/test/parallel/test-cluster-worker-disconnect.js
@@ -7,7 +7,7 @@ if (cluster.isWorker){
 const http = require('http');
 http.Server(() =>{
 
- }).listen(common.PORT, '127.0.0.1');
+ }).listen(0, '127.0.0.1');
 const worker = cluster.worker;
 assert.strictEqual(worker.exitedAfterDisconnect, worker.suicide);
 
diff --git a/test/parallel/test-cluster-worker-exit.js b/test/parallel/test-cluster-worker-exit.js
@@ -19,7 +19,7 @@ if (cluster.isWorker){
 server.once('listening', common.mustCall(() =>{
 process.exit(EXIT_CODE);
 }));
- server.listen(common.PORT, '127.0.0.1');
+ server.listen(0, '127.0.0.1');
 
 } else if (cluster.isMaster){
 
diff --git a/test/parallel/test-cluster-worker-kill.js b/test/parallel/test-cluster-worker-kill.js
@@ -15,7 +15,7 @@ if (cluster.isWorker){
 const server = http.Server(() =>{});
 
 server.once('listening', common.mustCall(() =>{}));
- server.listen(common.PORT, '127.0.0.1');
+ server.listen(0, '127.0.0.1');
 
 } else if (cluster.isMaster){
 

-Original file line number
+Diff line change
 consthttp=require('http');
 http.Server(()=>{
 -}).listen(common.PORT,'127.0.0.1');
 +}).listen(0,'127.0.0.1');
 constworker=cluster.worker;
 assert.strictEqual(worker.exitedAfterDisconnect,worker.suicide);
-Original file line number
+Diff line change
 server.once('listening',common.mustCall(()=>{
 process.exit(EXIT_CODE);
 }));
 -server.listen(common.PORT,'127.0.0.1');
 +server.listen(0,'127.0.0.1');
 }elseif(cluster.isMaster){