test: refactored http test to use countdown

mithunsasidharan · gibfahn · commit 3a0cb8fcae31 · 2017-12-19T22:25:42.000Z
PR-URL: #17241 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/test/parallel/test-http-end-throw-socket-handling.js b/test/parallel/test-http-end-throw-socket-handling.js
@@ -1,5 +1,6 @@
 'use strict';
 const common = require('../common');
+const Countdown = require('../common/countdown');
 
 // Make sure that throwing in 'end' handler doesn't lock
 // up the socket forever.
@@ -8,10 +9,10 @@ const common = require('../common');
 // the same, we should not be so brittle and easily broken.
 
 const http = require('http');
+const countdown = new Countdown(10, () => server.close());
 
-let n = 0;
 const server = http.createServer((req, res) =>{
- if (++n === 10) server.close();
+ countdown.dec();
 res.end('ok');
 });
 

-Original file line number
+Diff line change
@@ @@ -1,5 +1,6 @@ @@
 'use strict';
 constcommon=require('../common');
 +constCountdown=require('../common/countdown');
 // Make sure that throwing in 'end' handler doesn't lock
 // up the socket forever.
 // the same, we should not be so brittle and easily broken.
 consthttp=require('http');
 +constcountdown=newCountdown(10,()=>server.close());
 -letn=0;
 constserver=http.createServer((req,res)=>{
 -if(++n===10)server.close();
 +countdown.dec();
 res.end('ok');
 });