lib: return directly if udp socket close before lookup

PR-URL: #51914 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: theanarkh

lib/dgram.js

@@ -328,6 +328,9 @@ Socket.prototype.bind = function(port_, address_ /* , callback */){
 
 // Resolve address first
 state.handle.lookup(address,(err,ip)=>{
+if(!state.handle)
+return;// Handle has been closed in the mean time
+
 if(err){
 state.bindState=BIND_STATE_UNBOUND;
 this.emit('error',err);
@@ -356,9 +359,6 @@ Socket.prototype.bind = function(port_, address_ /* , callback */){
 this.emit('error',ex);
 });
 }else{
-if(!state.handle)
-return;// Handle has been closed in the mean time
-
 consterr=state.handle.bind(ip,port||0,flags);
 if(err){
 constex=newExceptionWithHostPort(err,'bind',ip,port);

test/parallel/test-dgram-bind-socket-close-before-lookup.js

@@ -0,0 +1,19 @@
+'use strict';
+constcommon=require('../common');
+constdgram=require('dgram');
+
+// Do not emit error event in callback which is called by lookup when socket is closed
+constsocket=dgram.createSocket({
+type: 'udp4',
+lookup: (...args)=>{
+// Call lookup callback after 1s
+setTimeout(()=>{
+args.at(-1)(newError('an error'));
+},1000);
+}
+});
+
+socket.on('error',common.mustNotCall());
+socket.bind(12345,'localhost');
+// Close the socket before calling DNS lookup callback
+socket.close();