test,async_hooks: stabilize tests on Windows

PR-URL: #13381 Reviewed-By: Andreas Madsen <[email protected]>

Author: refack

test/async-hooks/test-emit-before-after.js

@@ -16,13 +16,13 @@ switch (process.argv[2]){
 }
 
 constc1=spawnSync(process.execPath,[__filename,'test_invalid_async_id']);
-assert.strictEqual(c1.stderr.toString().split('\n')[0],
+assert.strictEqual(c1.stderr.toString().split(/[\r\n]+/g)[0],
 'Error: before(): asyncId or triggerAsyncId is less than '+
 'zero (asyncId: -1, triggerAsyncId: -1)');
 assert.strictEqual(c1.status,1);
 
 constc2=spawnSync(process.execPath,[__filename,'test_invalid_trigger_id']);
-assert.strictEqual(c2.stderr.toString().split('\n')[0],
+assert.strictEqual(c2.stderr.toString().split(/[\r\n]+/g)[0],
 'Error: before(): asyncId or triggerAsyncId is less than '+
 'zero (asyncId: 1, triggerAsyncId: -1)');
 assert.strictEqual(c2.status,1);

test/async-hooks/test-graph.signal.js

@@ -1,6 +1,11 @@
 'use strict';
 
 constcommon=require('../common');
+if(common.isWindows){
+common.skip('no signals on Windows');
+return;
+}
+
 constinitHooks=require('./init-hooks');
 constverifyGraph=require('./verify-graph');
 constexec=require('child_process').exec;

test/async-hooks/test-signalwrap.js

@@ -1,6 +1,8 @@
 'use strict';
-
 constcommon=require('../common');
+
+if(common.isWindows)returncommon.skip('no signals in Windows');
+
 constassert=require('assert');
 constinitHooks=require('./init-hooks');
 const{ checkInvocations }=require('./hook-checks');

test/async-hooks/test-ttywrap.readstream.js

@@ -1,42 +1,44 @@
 'use strict';
-
 constcommon=require('../common');
 constassert=require('assert');
+
+// general hook test setup
 consttick=require('./tick');
 constinitHooks=require('./init-hooks');
 const{ checkInvocations }=require('./hook-checks');
 
 consthooks=initHooks();
 hooks.enable();
 
-constReadStream=require('tty').ReadStream;
-constttyStream=newReadStream(0);
-
-constas=hooks.activitiesOfTypes('TTYWRAP');
-assert.strictEqual(as.length,1);
-consttty=as[0];
+// test specific setup
+const{ ReadStream }=require('tty');
+constcheckInitOpts={init: 1};
+constcheckEndedOpts={init: 1,before: 1,after: 1,destroy: 1};
+
+// test code
+//
+// listen to stdin except on Windows
+consttargetFD=common.isWindows ? 1 : 0;
+constttyStream=newReadStream(targetFD);
+constactivities=hooks.activitiesOfTypes('TTYWRAP');
+assert.strictEqual(activities.length,1);
+consttty=activities[0];
 assert.strictEqual(tty.type,'TTYWRAP');
 assert.strictEqual(typeoftty.uid,'number');
 assert.strictEqual(typeoftty.triggerAsyncId,'number');
-checkInvocations(tty,{init: 1},'when tty created');
-
-ttyStream.end(common.mustCall(onend));
-
-checkInvocations(tty,{init: 1},'when tty.end() was invoked ');
-
-functiononend(){
-tick(2,common.mustCall(()=>
-checkInvocations(
-tty,{init: 1,before: 1,after: 1,destroy: 1},
-'when tty ended ')
-));
-}
-
-process.on('exit',onexit);
-
-functiononexit(){
+checkInvocations(tty,checkInitOpts,'when tty created');
+constdelayedOnCloseHandler=common.mustCall(()=>{
+checkInvocations(tty,checkEndedOpts,'when tty ended');
+});
+ttyStream.on('error',(err)=>assert.fail(err));
+ttyStream.on('close',common.mustCall(()=>
+tick(2,delayedOnCloseHandler)
+));
+ttyStream.destroy();
+checkInvocations(tty,checkInitOpts,'when tty.end() was invoked');
+
+process.on('exit',()=>{
 hooks.disable();
 hooks.sanityCheck('TTYWRAP');
-checkInvocations(tty,{init: 1,before: 1,after: 1,destroy: 1},
-'when process exits');
-}
+checkInvocations(tty,checkEndedOpts,'when process exits');
+});