tools: simplify prefer-common-mustnotcall rule

PR-URL: #17572 Reviewed-By: Anatoli Papirovski <[email protected]>

Author: cjihrig

tools/eslint-rules/prefer-common-mustnotcall.js

@@ -10,30 +10,21 @@
 
 constmsg='Please use common.mustNotCall(msg) instead of '+
 'common.mustCall(fn, 0) or common.mustCall(0).';
-
-functionisCommonMustCall(node){
-returnnode&&
-node.callee&&
-node.callee.object&&
-node.callee.object.name==='common'&&
-node.callee.property&&
-node.callee.property.name==='mustCall';
-}
-
-functionisArgZero(argument){
-returnargument&&
-typeofargument.value==='number'&&
-argument.value===0;
-}
+constmustCallSelector='CallExpression[callee.object.name="common"]'+
+'[callee.property.name="mustCall"]';
+constarg0Selector=`${mustCallSelector}[arguments.0.value=0]`;
+constarg1Selector=`${mustCallSelector}[arguments.1.value=0]`;
 
 module.exports=function(context){
+functionreport(node){
+context.report(node,msg);
+}
+
 return{
-CallExpression(node){
-if(isCommonMustCall(node)&&
-(isArgZero(node.arguments[0])||// catch common.mustCall(0)
-isArgZero(node.arguments[1]))){// catch common.mustCall(fn, 0)
-context.report(node,msg);
-}
-}
+// Catch common.mustCall(0)
+[arg0Selector]: report,
+
+// Catch common.mustCall(fn, 0)
+[arg1Selector]: report
 };
 };