test_runner: remove redundant bootstrap boolean

The test runner bootstrap process awaits a Promise and then sets a boolean flag. This commit consolidates the Promise and boolean into a single value. This commit also ensures that the globalRoot test is always assigned in createTestTree() in order to better consolidate the CLI/run() and non-CLI configuration. PR-URL: #54013 Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>

Author: cjihrig

lib/internal/test_runner/harness.js

@@ -28,18 +28,20 @@ const{
 }=require('internal/test_runner/utils');
 const{ queueMicrotask }=require('internal/process/task_queues');
 const{bigint: hrtime}=process.hrtime;
-
+constresolvedPromise=PromiseResolve();
 consttestResources=newSafeMap();
+letglobalRoot;
 
 testResources.set(reporterScope.asyncId(),reporterScope);
 
 functioncreateTestTree(options=kEmptyObject){
-returnsetup(newTest({__proto__: null, ...options,name: '<root>'}));
+globalRoot=setup(newTest({__proto__: null, ...options,name: '<root>'}));
+returnglobalRoot;
 }
 
 functioncreateProcessEventHandler(eventName,rootTest){
 return(err)=>{
-if(!rootTest.harness.bootstrapComplete){
+if(rootTest.harness.bootstrapPromise){
 // Something went wrong during the asynchronous portion of bootstrapping
 // the test runner. Since the test runner is not setup properly, we can't
 // do anything but throw the error.
@@ -196,7 +198,7 @@ function setup(root){
 root.harness={
 __proto__: null,
 allowTestsToRun: false,
-bootstrapComplete: false,
+bootstrapPromise: resolvedPromise,
 watching: false,
 coverage: FunctionPrototypeBind(collectCoverage,null,root,coverage),
 resetCounters(){
@@ -222,33 +224,30 @@ function setup(root){
 returnroot;
 }
 
-letglobalRoot;
-letasyncBootstrap;
 functionlazyBootstrapRoot(){
 if(!globalRoot){
-globalRoot=createTestTree({__proto__: null,entryFile: process.argv?.[1]});
+// This is where the test runner is bootstrapped when node:test is used
+// without the --test flag or the run() API.
+createTestTree({__proto__: null,entryFile: process.argv?.[1]});
 globalRoot.reporter.on('test:fail',(data)=>{
 if(data.todo===undefined||data.todo===false){
 process.exitCode=kGenericUserError;
 }
 });
-asyncBootstrap=setupTestReporters(globalRoot.reporter);
+globalRoot.harness.bootstrapPromise=setupTestReporters(globalRoot.reporter);
 }
 returnglobalRoot;
 }
 
-asyncfunctionstartSubtest(subtest){
-if(asyncBootstrap){
+asyncfunctionstartSubtestAfterBootstrap(subtest){
+if(subtest.root.harness.bootstrapPromise){
 // Only incur the overhead of awaiting the Promise once.
-awaitasyncBootstrap;
-asyncBootstrap=undefined;
-if(!subtest.root.harness.bootstrapComplete){
-subtest.root.harness.bootstrapComplete=true;
-queueMicrotask(()=>{
-subtest.root.harness.allowTestsToRun=true;
-subtest.root.processPendingSubtests();
-});
-}
+awaitsubtest.root.harness.bootstrapPromise;
+subtest.root.harness.bootstrapPromise=null;
+queueMicrotask(()=>{
+subtest.root.harness.allowTestsToRun=true;
+subtest.root.processPendingSubtests();
+});
 }
 
 awaitsubtest.start();
@@ -262,7 +261,7 @@ function runInParentContext(Factory){
 returnPromiseResolve();
 }
 
-returnstartSubtest(subtest);
+returnstartSubtestAfterBootstrap(subtest);
 }
 
 consttest=(name,options,fn)=>{

lib/internal/test_runner/runner.js

@@ -596,7 +596,7 @@ function run(options = kEmptyObject){
 teardown=undefined;
 }
 construnFiles=()=>{
-root.harness.bootstrapComplete=true;
+root.harness.bootstrapPromise=null;
 root.harness.allowTestsToRun=true;
 returnSafePromiseAllSettledReturnVoid(testFiles,(path)=>{
 constsubtest=runTestFile(path,filesWatcher,opts);