test: refactor test-crypto-padding.js

- Replaced var with const and let. - Replaced assert.equal() with assert.strictEqual(). - Added error message checking for assert.throws(). PR-URL: #9971 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Prince John Wesley <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: Konstantin Likhter

test/parallel/test-crypto-padding.js

@@ -1,12 +1,12 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
+constcommon=require('../common');
+constassert=require('assert');
 
 if(!common.hasCrypto){
 common.skip('missing crypto');
 return;
 }
-varcrypto=require('crypto');
+constcrypto=require('crypto');
 
 crypto.DEFAULT_ENCODING='buffer';
 
@@ -21,7 +21,7 @@ const EVEN_LENGTH_PLAIN = 'Hello node world!AbC09876dDeFgHi'
 constKEY_PLAIN='S3c.r.e.t.K.e.Y!';
 constIV_PLAIN='blahFizz2011Buzz';
 
-varCIPHER_NAME='aes-128-cbc';
+constCIPHER_NAME='aes-128-cbc';
 
 
 /*
@@ -31,20 +31,20 @@ var CIPHER_NAME = 'aes-128-cbc'
 // echo -n 'Hello node world!' | \
 // openssl enc -aes-128-cbc -e -K 5333632e722e652e742e4b2e652e5921 \
 // -iv 626c616846697a7a3230313142757a7a | xxd -p -c256
-varODD_LENGTH_ENCRYPTED=
+constODD_LENGTH_ENCRYPTED=
 '7f57859550d4d2fdb9806da2a750461a9fe77253cd1cbd4b07beee4e070d561f';
 
 // echo -n 'Hello node world!AbC09876dDeFgHi' | \
 // openssl enc -aes-128-cbc -e -K 5333632e722e652e742e4b2e652e5921 \
 // -iv 626c616846697a7a3230313142757a7a | xxd -p -c256
-varEVEN_LENGTH_ENCRYPTED=
+constEVEN_LENGTH_ENCRYPTED=
 '7f57859550d4d2fdb9806da2a750461ab46e71b3d78ebe2d9684dfc87f7575b988'+
 '6119866912cb8c7bcaf76c5ebc2378';
 
 // echo -n 'Hello node world!AbC09876dDeFgHi' | \
 // openssl enc -aes-128-cbc -e -K 5333632e722e652e742e4b2e652e5921 \
 // -iv 626c616846697a7a3230313142757a7a -nopad | xxd -p -c256
-varEVEN_LENGTH_ENCRYPTED_NOPAD=
+constEVEN_LENGTH_ENCRYPTED_NOPAD=
 '7f57859550d4d2fdb9806da2a750461ab46e'+
 '71b3d78ebe2d9684dfc87f7575b9';
 
@@ -54,17 +54,17 @@ var EVEN_LENGTH_ENCRYPTED_NOPAD =
  */
 
 functionenc(plain,pad){
-varencrypt=crypto.createCipheriv(CIPHER_NAME,KEY_PLAIN,IV_PLAIN);
+constencrypt=crypto.createCipheriv(CIPHER_NAME,KEY_PLAIN,IV_PLAIN);
 encrypt.setAutoPadding(pad);
-varhex=encrypt.update(plain,'ascii','hex');
+lethex=encrypt.update(plain,'ascii','hex');
 hex+=encrypt.final('hex');
 returnhex;
 }
 
 functiondec(encd,pad){
-vardecrypt=crypto.createDecipheriv(CIPHER_NAME,KEY_PLAIN,IV_PLAIN);
+constdecrypt=crypto.createDecipheriv(CIPHER_NAME,KEY_PLAIN,IV_PLAIN);
 decrypt.setAutoPadding(pad);
-varplain=decrypt.update(encd,'hex');
+letplain=decrypt.update(encd,'hex');
 plain+=decrypt.final('latin1');
 returnplain;
 }
@@ -104,9 +104,7 @@ assert.doesNotThrow(function(){
 
 assert.throws(function(){
 // must have at least 1 byte of padding (PKCS):
-assert.strictEqual(
-dec(EVEN_LENGTH_ENCRYPTED_NOPAD,true),EVEN_LENGTH_PLAIN
-);
+assert.strictEqual(dec(EVEN_LENGTH_ENCRYPTED_NOPAD,true),EVEN_LENGTH_PLAIN);
 },/baddecrypt/);
 
 assert.doesNotThrow(function(){