lib: remove let from for loops

This is a known de-opt. It may not be 100% necessary in all cases but it seems like a decent enough idea to avoid it. Ref: #9553 PR-URL: #8873 Reviewed-By: Brian White <[email protected]> Reviewed-By: Ilkka Myller <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: Myles Borins

lib/_stream_readable.js

@@ -654,14 +654,14 @@ Readable.prototype.unpipe = function(dest){
 state.pipesCount=0;
 state.flowing=false;
 
-for(leti=0;i<len;i++)
+for(vari=0;i<len;i++)
 dests[i].emit('unpipe',this);
 returnthis;
 }
 
 // try to find the right one.
-consti=state.pipes.indexOf(dest);
-if(i===-1)
+constindex=state.pipes.indexOf(dest);
+if(index===-1)
 returnthis;
 
 state.pipes.splice(i,1);

lib/_tls_common.js

@@ -34,6 +34,8 @@ exports.SecureContext = SecureContext;
 
 exports.createSecureContext=functioncreateSecureContext(options,context){
 if(!options)options={};
+vari;
+varlen;
 
 varsecureOptions=options.secureOptions;
 if(options.honorCipherOrder)
@@ -47,7 +49,7 @@ exports.createSecureContext = function createSecureContext(options, context){
 // cert's issuer in C++ code.
 if(options.ca){
 if(Array.isArray(options.ca)){
-for(leti=0,len=options.ca.length;i<len;i++){
+for(i=0,len=options.ca.length;i<len;i++){
 c.context.addCACert(options.ca[i]);
 }
 }else{
@@ -59,7 +61,7 @@ exports.createSecureContext = function createSecureContext(options, context){
 
 if(options.cert){
 if(Array.isArray(options.cert)){
-for(leti=0;i<options.cert.length;i++)
+for(i=0;i<options.cert.length;i++)
 c.context.setCert(options.cert[i]);
 }else{
 c.context.setCert(options.cert);
@@ -72,7 +74,7 @@ exports.createSecureContext = function createSecureContext(options, context){
 // which leads to the crash later on.
 if(options.key){
 if(Array.isArray(options.key)){
-for(leti=0;i<options.key.length;i++){
+for(i=0;i<options.key.length;i++){
 varkey=options.key[i];
 
 if(key.passphrase)
@@ -103,7 +105,7 @@ exports.createSecureContext = function createSecureContext(options, context){
 
 if(options.crl){
 if(Array.isArray(options.crl)){
-for(leti=0,len=options.crl.length;i<len;i++){
+for(i=0,len=options.crl.length;i<len;i++){
 c.context.addCRL(options.crl[i]);
 }
 }else{

lib/repl.js

@@ -286,7 +286,7 @@ function REPLServer(prompt,
 
 // After executing the current expression, store the values of RegExp
 // predefined properties back in `savedRegExMatches`
-for(letidx=1;idx<savedRegExMatches.length;idx+=1){
+for(varidx=1;idx<savedRegExMatches.length;idx+=1){
 savedRegExMatches[idx]=RegExp[`$${idx}`];
 }
 

lib/tls.js

@@ -90,7 +90,7 @@ function check(hostParts, pattern, wildcards){
 returnfalse;
 
 // Check host parts from right to left first.
-for(leti=hostParts.length-1;i>0;i-=1)
+for(vari=hostParts.length-1;i>0;i-=1)
 if(hostParts[i]!==patternParts[i])
 returnfalse;
 

lib/url.js

@@ -89,7 +89,7 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost){
 if(typeofurl!=='string'){
 thrownewTypeError("Parameter 'url' must be a string, not "+typeofurl);
 }
-
+vari,j,k,l;
 // Copy chrome, IE, opera backslash-handling behavior.
 // Back slashes before the query string get converted to forward slashes
 // See: https://code.google.com/p/chromium/issues/detail?id=25916
@@ -169,7 +169,7 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost){
 
 // find the first instance of any hostEndingChars
 varhostEnd=-1;
-for(leti=0;i<hostEndingChars.length;i++){
+for(i=0;i<hostEndingChars.length;i++){
 consthec=rest.indexOf(hostEndingChars[i]);
 if(hec!==-1&&(hostEnd===-1||hec<hostEnd))
 hostEnd=hec;
@@ -197,7 +197,7 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost){
 
 // the host is the remaining to the left of the first non-host char
 hostEnd=-1;
-for(leti=0;i<nonHostChars.length;i++){
+for(i=0;i<nonHostChars.length;i++){
 consthec=rest.indexOf(nonHostChars[i]);
 if(hec!==-1&&(hostEnd===-1||hec<hostEnd))
 hostEnd=hec;
@@ -224,12 +224,12 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost){
 // validate a little.
 if(!ipv6Hostname){
 varhostparts=this.hostname.split(/\./);
-for(leti=0,l=hostparts.length;i<l;i++){
+for(i=0,l=hostparts.length;i<l;i++){
 varpart=hostparts[i];
 if(!part)continue;
 if(!part.match(hostnamePartPattern)){
 varnewpart='';
-for(letj=0,k=part.length;j<k;j++){
+for(j=0,k=part.length;j<k;j++){
 if(part.charCodeAt(j)>127){
 // we replace non-ASCII char with a temporary placeholder
 // we need this to make sure size of hostname is not
@@ -294,7 +294,7 @@ Url.prototype.parse = function(url, parseQueryString, slashesDenoteHost){
 // First, make 100% sure that any "autoEscape" chars get
 // escaped, even if encodeURIComponent doesn't think they
 // need to be.
-for(leti=0,l=autoEscape.length;i<l;i++){
+for(i=0,l=autoEscape.length;i<l;i++){
 varae=autoEscape[i];
 if(rest.indexOf(ae)===-1)
 continue;