Skip to content

Commit 441e8fe

Browse files
Trottevanlucas
authored andcommitted
test: refactor test-timers-linked-list.js
* check that empty linked lists have identical properties * `assert.equal()` -> `assert.strictEqual()` * `var` -> `const` PR-URL: #8193 Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
1 parent bb6d6a6 commit 441e8fe

File tree

1 file changed

+31
-30
lines changed

1 file changed

+31
-30
lines changed

‎test/parallel/test-timers-linked-list.js‎

Lines changed: 31 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ const internalL = require('internal/linkedlist');
99

1010
assert.strictEqual(L,internalL);
1111

12-
varlist={name: 'list'};
13-
varA={name: 'A'};
14-
varB={name: 'B'};
15-
varC={name: 'C'};
16-
varD={name: 'D'};
12+
constlist={name: 'list'};
13+
constA={name: 'A'};
14+
constB={name: 'B'};
15+
constC={name: 'C'};
16+
constD={name: 'D'};
1717

1818

1919
L.init(list);
@@ -23,63 +23,61 @@ L.init(C);
2323
L.init(D);
2424

2525
assert.ok(L.isEmpty(list));
26-
assert.equal(null,L.peek(list));
26+
assert.strictEqual(null,L.peek(list));
2727

2828
L.append(list,A);
2929
// list -> A
30-
assert.equal(A,L.peek(list));
30+
assert.strictEqual(A,L.peek(list));
3131

3232
L.append(list,B);
3333
// list -> A -> B
34-
assert.equal(A,L.peek(list));
34+
assert.strictEqual(A,L.peek(list));
3535

3636
L.append(list,C);
3737
// list -> A -> B -> C
38-
assert.equal(A,L.peek(list));
38+
assert.strictEqual(A,L.peek(list));
3939

4040
L.append(list,D);
4141
// list -> A -> B -> C -> D
42-
assert.equal(A,L.peek(list));
42+
assert.strictEqual(A,L.peek(list));
4343

44-
varx=L.shift(list);
45-
assert.equal(A,x);
44+
assert.strictEqual(A,L.shift(list));
4645
// list -> B -> C -> D
47-
assert.equal(B,L.peek(list));
46+
assert.strictEqual(B,L.peek(list));
4847

49-
x=L.shift(list);
50-
assert.equal(B,x);
48+
assert.strictEqual(B,L.shift(list));
5149
// list -> C -> D
52-
assert.equal(C,L.peek(list));
50+
assert.strictEqual(C,L.peek(list));
5351

5452
// B is already removed, so removing it again shouldn't hurt.
5553
L.remove(B);
5654
// list -> C -> D
57-
assert.equal(C,L.peek(list));
55+
assert.strictEqual(C,L.peek(list));
5856

5957
// Put B back on the list
6058
L.append(list,B);
6159
// list -> C -> D -> B
62-
assert.equal(C,L.peek(list));
60+
assert.strictEqual(C,L.peek(list));
6361

6462
L.remove(C);
6563
// list -> D -> B
66-
assert.equal(D,L.peek(list));
64+
assert.strictEqual(D,L.peek(list));
6765

6866
L.remove(B);
6967
// list -> D
70-
assert.equal(D,L.peek(list));
68+
assert.strictEqual(D,L.peek(list));
7169

7270
L.remove(D);
7371
// list
74-
assert.equal(null,L.peek(list));
72+
assert.strictEqual(null,L.peek(list));
7573

7674

7775
assert.ok(L.isEmpty(list));
7876

7977

8078
L.append(list,D);
8179
// list -> D
82-
assert.equal(D,L.peek(list));
80+
assert.strictEqual(D,L.peek(list));
8381

8482
L.append(list,C);
8583
L.append(list,B);
@@ -90,21 +88,24 @@ L.append(list, A);
9088
L.append(list,C);
9189

9290
// list -> D -> B -> A -> C
93-
assert.equal(D,L.shift(list));
91+
assert.strictEqual(D,L.shift(list));
9492
// list -> B -> A -> C
95-
assert.equal(B,L.peek(list));
96-
assert.equal(B,L.shift(list));
93+
assert.strictEqual(B,L.peek(list));
94+
assert.strictEqual(B,L.shift(list));
9795
// list -> A -> C
98-
assert.equal(A,L.peek(list));
99-
assert.equal(A,L.shift(list));
96+
assert.strictEqual(A,L.peek(list));
97+
assert.strictEqual(A,L.shift(list));
10098
// list -> C
101-
assert.equal(C,L.peek(list));
102-
assert.equal(C,L.shift(list));
99+
assert.strictEqual(C,L.peek(list));
100+
assert.strictEqual(C,L.shift(list));
103101
// list
104102
assert.ok(L.isEmpty(list));
105103

106104
constlist2=L.create();
107105
constlist3=L.create();
108106
assert.ok(L.isEmpty(list2));
109107
assert.ok(L.isEmpty(list3));
110-
assert.ok(list2!=list3);
108+
109+
// Objects should have identical keys/properties, but be different objects.
110+
assert.deepStrictEqual(list2,list3);
111+
assert.notStrictEqual(list2,list3);

0 commit comments

Comments
(0)