lib: add comments to empty catch statements

PR-URL: #41831 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: Trott

lib/events.js

@@ -445,7 +445,9 @@ function enhanceStackTrace(err, own){
 const{ name }=this.constructor;
 if(name!=='EventEmitter')
 ctorInfo=` on ${name} instance`;
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 constsep=`\nEmitted 'error' event${ctorInfo} at:\n`;
 
 consterrStack=ArrayPrototypeSlice(
@@ -493,7 +495,9 @@ EventEmitter.prototype.emit = function emit(type, ...args){
 value: FunctionPrototypeBind(enhanceStackTrace,this,er,capture),
 configurable: true
 });
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 
 // Note: The comments on the `throw` lines are intentional, they show
 // up in Node's output if this results in an unhandled exception.

lib/fs.js

@@ -1600,7 +1600,9 @@ function symlink(target, path, type_, callback_){
 // errors consistent between platforms if invalid path is
 // provided.
 absoluteTarget=pathModule.resolve(path,'..',target);
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 if(absoluteTarget!==undefined){
 stat(absoluteTarget,(err,stat)=>{
 constresolvedType=!err&&stat.isDirectory() ? 'dir' : 'file';

lib/internal/bootstrap/pre_execution.js

@@ -101,7 +101,9 @@ function patchProcessObject(expandArgv1){
 constpath=require('path');
 try{
 process.argv[1]=path.resolve(process.argv[1]);
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 }
 
 // TODO(joyeecheung): most of these should be deprecated and removed,

lib/internal/error_serdes.js

@@ -48,7 +48,9 @@ function TryGetAllProperties(object, target = object){
 if(getter&&key!=='__proto__'){
 try{
 descriptor.value=FunctionPrototypeCall(getter,target);
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 }
 if('value'indescriptor&&typeofdescriptor.value!=='function'){
 deletedescriptor.get;
@@ -107,11 +109,15 @@ function serializeError(error){
 }
 }
 }
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 try{
 constserialized=serialize(error);
 returnBuffer.concat([Buffer.from([kSerializedObject]),serialized]);
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 returnBuffer.concat([Buffer.from([kInspectedError]),
 Buffer.from(inspect(error),'utf8')]);
 }

lib/internal/main/worker_thread.js

@@ -226,14 +226,18 @@ function workerOnGlobalUncaughtException(error, fromPromise){
 if(!handlerThrew){
 process.emit('exit',process.exitCode);
 }
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 }
 
 letserialized;
 try{
 const{ serializeError }=require('internal/error_serdes');
 serialized=serializeError(error);
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 debug(`[${threadId}] uncaught exception serialized = ${!!serialized}`);
 if(serialized)
 port.postMessage({

lib/internal/modules/cjs/loader.js

@@ -1128,7 +1128,9 @@ Module._extensions['.js'] = function(module, filename){
 letparentSource;
 try{
 parentSource=fs.readFileSync(parentPath,'utf8');
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 if(parentSource){
 consterrLine=StringPrototypeSplit(
 StringPrototypeSlice(err.stack,StringPrototypeIndexOf(

lib/internal/modules/esm/module_job.js

@@ -154,7 +154,9 @@ class ModuleJob{
 // care about CommonJS for the purposes of this error message.
 ({ format }=
 awaitthis.loader.load(childFileURL));
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 
 if(format==='commonjs'){
 constimportStatement=splitStack[1];

lib/internal/modules/esm/resolve.js

@@ -474,7 +474,9 @@ function resolvePackageTargetString(
 try{
 newURL(target);
 isURL=true;
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 if(!isURL){
 constexportTarget=pattern ?
 RegExpPrototypeSymbolReplace(patternRegEx,target,()=>subpath) :

lib/internal/modules/esm/translators.js

@@ -180,7 +180,9 @@ translators.set('commonjs', async function commonjsStrategy(url, source,
 letvalue;
 try{
 value=exports[exportName];
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 this.setExport(exportName,value);
 }
 this.setExport('default',exports);
@@ -205,7 +207,9 @@ function cjsPreparseModuleExports(filename){
 letsource;
 try{
 source=readFileSync(filename,'utf8');
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 
 letexports,reexports;
 try{

lib/internal/policy/manifest.js

@@ -639,7 +639,9 @@ function canonicalizeSpecifier(specifier, base){
 returnresolve(specifier,base).href;
 }
 returnresolve(specifier).href;
-}catch{}
+}catch{
+// Continue regardless of error.
+}
 returnspecifier;
 }