repl: don't crash if cannot open history file

Previously, if we are unable to open the history file, an error would be thrown. Now, print an error message that we could not open the history file, but don't fail. Fixes: #3610 PR-URL: #3630 Reviewed-By: Jeremiah Senkpiel <[email protected]>

Author: evanlucas

lib/internal/repl.js

@@ -92,7 +92,16 @@ function setupHistory(repl, historyPath, oldHistoryPath, ready){
 
 functiononinit(err,hnd){
 if(err){
-returnready(err);
+// Cannot open history file.
+// Don't crash, just don't persist history.
+repl._writeToOutput('\nError: Could not open history file.\n'+
+'REPL session history will not be persisted.\n');
+repl._refreshLine();
+debug(err.stack);
+
+repl._historyPrev=_replHistoryMessage;
+repl.resume();
+returnready(null,repl);
 }
 fs.close(hnd,onclose);
 }

test/sequential/test-repl-persistent-history.js

@@ -64,10 +64,13 @@ const convertMsg = '\nConverting old JSON repl history to line-separated ' +
 path.join(common.tmpDir,'.node_repl_history')+'.\n';
 consthomedirErr='\nError: Could not get the home directory.\n'+
 'REPL session history will not be persisted.\n';
+constreplFailedRead='\nError: Could not open history file.\n'+
+'REPL session history will not be persisted.\n';
 // File paths
 constfixtures=path.join(common.testDir,'fixtures');
 consthistoryFixturePath=path.join(fixtures,'.node_repl_history');
 consthistoryPath=path.join(common.tmpDir,'.fixture_copy_repl_history');
+consthistoryPathFail=path.join(common.tmpDir,'.node_repl\u0000_history');
 constoldHistoryPath=path.join(fixtures,'old-repl-history-file.json');
 constenoentHistoryPath=path.join(fixtures,'enoent-repl-history-file.json');
 constdefaultHistoryPath=path.join(common.tmpDir,'.node_repl_history');
@@ -147,6 +150,12 @@ const tests = [{
 test: [UP,UP,UP,CLEAR],
 expected: [prompt,convertMsg,prompt,prompt+'\'=^.^=\'',prompt]
 },
+{
+env: {NODE_REPL_HISTORY: historyPathFail,
+NODE_REPL_HISTORY_SIZE: 1},
+test: [UP],
+expected: [prompt,replFailedRead,prompt,replDisabled,prompt]
+},
 {// Make sure this is always the last test, since we change os.homedir()
 before: functionmockHomedirFailure(){
 // Mock os.homedir() failure