test: scope redeclared vars in test-child-process*

A handful of child process tests had variables declared multiple times in the same scope using `var`. This change scopes those declarations. PR-URL: #4944 Reviewed-By: Michaël Zasso <[email protected]>

Author: Trott

test/parallel/test-child-process-default-options.js

@@ -6,10 +6,11 @@ var spawn = require('child_process').spawn;
 
 process.env.HELLO='WORLD';
 
+varchild;
 if(common.isWindows){
-varchild=spawn('cmd.exe',['/c','set'],{});
+child=spawn('cmd.exe',['/c','set'],{});
 }else{
-varchild=spawn('/usr/bin/env',[],{});
+child=spawn('/usr/bin/env',[],{});
 }
 
 varresponse='';

test/parallel/test-child-process-env.js

@@ -11,10 +11,11 @@ env.__proto__ ={
 'FOO': 'BAR'
 };
 
+varchild;
 if(common.isWindows){
-varchild=spawn('cmd.exe',['/c','set'],{env: env});
+child=spawn('cmd.exe',['/c','set'],{env: env});
 }else{
-varchild=spawn('/usr/bin/env',[],{env: env});
+child=spawn('/usr/bin/env',[],{env: env});
 }
 
 

test/parallel/test-child-process-fork-dgram.js

@@ -24,9 +24,8 @@ if (common.isWindows){
 return;
 }
 
+varserver;
 if(process.argv[2]==='child'){
-varserver;
-
 process.on('message',functionremoveMe(msg,clusterServer){
 if(msg==='server'){
 server=clusterServer;
@@ -42,7 +41,7 @@ if (process.argv[2] === 'child'){
 });
 
 }else{
-varserver=dgram.createSocket('udp4');
+server=dgram.createSocket('udp4');
 varclient=dgram.createSocket('udp4');
 varchild=fork(__filename,['child']);
 

test/parallel/test-child-process-silent.js

@@ -4,11 +4,11 @@ var assert = require('assert');
 varchildProcess=require('child_process');
 
 // Child pipe test
-if(process.argv[2]==='pipetest'){
+if(process.argv[2]==='pipe'){
 process.stdout.write('stdout message');
 process.stderr.write('stderr message');
 
-}elseif(process.argv[2]==='ipctest'){
+}elseif(process.argv[2]==='ipc'){
 // Child IPC test
 process.send('message from child');
 process.on('message',function(){
@@ -18,7 +18,7 @@ if (process.argv[2] === 'pipetest'){
 }elseif(process.argv[2]==='parent'){
 // Parent | start child pipe test
 
-varchild=childProcess.fork(process.argv[1],['pipetest'],{silent: true});
+constchild=childProcess.fork(process.argv[1],['pipe'],{silent: true});
 
 // Allow child process to self terminate
 child._channel.close();
@@ -46,7 +46,7 @@ if (process.argv[2] === 'pipetest'){
 });
 
 // testing: do message system work when using silent
-varchild=childProcess.fork(process.argv[1],['ipctest'],{silent: true});
+constchild=childProcess.fork(process.argv[1],['ipc'],{silent: true});
 
 // Manual pipe so we will get errors
 child.stderr.pipe(process.stderr,{end: false});

test/parallel/test-child-process-stdio-big-write-end.js

@@ -36,7 +36,7 @@ function parent(){
 
 // then write a bunch more times.
 for(vari=0;i<100;i++){
-varbuf=newBuffer(BUFSIZE);
+constbuf=newBuffer(BUFSIZE);
 buf.fill('.');
 sent+=BUFSIZE;
 child.stdin.write(buf);

test/parallel/test-child-process-validate-stdio.js

@@ -2,8 +2,8 @@
 // Flags: --expose_internals
 
 require('../common');
-varassert=require('assert');
-var_validateStdio=require('internal/child_process')._validateStdio;
+constassert=require('assert');
+const_validateStdio=require('internal/child_process')._validateStdio;
 
 // should throw if string and not ignore, pipe, or inherit
 assert.throws(function(){
@@ -16,27 +16,31 @@ assert.throws(function(){
 },/Incorrectvalueofstdiooption/);
 
 // should populate stdio with undefined if len < 3
-varstdio1=[];
-varresult=_validateStdio(stdio1,false);
-assert.equal(stdio1.length,3);
-assert.equal(result.hasOwnProperty('stdio'),true);
-assert.equal(result.hasOwnProperty('ipc'),true);
-assert.equal(result.hasOwnProperty('ipcFd'),true);
+{
+conststdio1=[];
+constresult=_validateStdio(stdio1,false);
+assert.equal(stdio1.length,3);
+assert.equal(result.hasOwnProperty('stdio'),true);
+assert.equal(result.hasOwnProperty('ipc'),true);
+assert.equal(result.hasOwnProperty('ipcFd'),true);
+}
 
 // should throw if stdio has ipc and sync is true
-varstdio2=['ipc','ipc','ipc'];
+conststdio2=['ipc','ipc','ipc'];
 assert.throws(function(){
 _validateStdio(stdio2,true);
 },/YoucannotuseIPCwithsynchronousforks/);
 
-conststdio3=[process.stdin,process.stdout,process.stderr];
-varresult=_validateStdio(stdio3,false);
-assert.deepStrictEqual(result,{
-stdio: [
-{type: 'fd',fd: 0},
-{type: 'fd',fd: 1},
-{type: 'fd',fd: 2}
-],
-ipc: undefined,
-ipcFd: undefined
-});
+{
+conststdio3=[process.stdin,process.stdout,process.stderr];
+constresult=_validateStdio(stdio3,false);
+assert.deepStrictEqual(result,{
+stdio: [
+{type: 'fd',fd: 0},
+{type: 'fd',fd: 1},
+{type: 'fd',fd: 2}
+],
+ipc: undefined,
+ipcFd: undefined
+});
+}