process: delay throwing an error using throwDeprecation

This makes sure all warnings that were triggered before a deprecation warning during the same tick are properly handled and logged. It also guarantees that users can not catch the error anymore. Fixes: #17871 PR-URL: #32312 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: BridgeAR

lib/internal/process/warning.js

@@ -126,8 +126,13 @@ function emitWarning(warning, type, code, ctor){
 if(warning.name==='DeprecationWarning'){
 if(process.noDeprecation)
 return;
-if(process.throwDeprecation)
-throwwarning;
+if(process.throwDeprecation){
+// Delay throwing the error to guarantee that all former warnings were
+// properly logged.
+returnprocess.nextTick(()=>{
+throwwarning;
+});
+}
 }
 process.nextTick(doEmitWarning,warning);
 }

test/parallel/test-process-warning.js

@@ -38,9 +38,14 @@ function test4(){
 // process.emitWarning will throw when process.throwDeprecation is true
 // and type is `DeprecationWarning`.
 process.throwDeprecation=true;
-assert.throws(
-()=>process.emitWarning('test','DeprecationWarning'),
-/^DeprecationWarning:test$/);
+process.once('uncaughtException',(err)=>{
+assert.match(err.toString(),/^DeprecationWarning:test$/);
+});
+try{
+process.emitWarning('test','DeprecationWarning');
+}catch{
+assert.fail('Unreachable');
+}
 process.throwDeprecation=false;
 setImmediate(test5);
 }