http2: fix no response event on continue request

When sending a continue request, server response with null, it does not fires the response event type Fixes: #38258 PR-URL: #41739 Refs: #38561 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: ofirbarak

lib/internal/http2/core.js

@@ -394,8 +394,7 @@ function onSessionHeaders(handle, id, cat, flags, headers, sensitiveHeaders){
 }
 }elseif(cat===NGHTTP2_HCAT_PUSH_RESPONSE){
 event='push';
-// cat === NGHTTP2_HCAT_HEADERS:
-}elseif(!endOfStream&&status!==undefined&&status>=200){
+}elseif(status!==undefined&&status>=200){
 event='response';
 }else{
 event=endOfStream ? 'trailers' : 'headers';

test/parallel/test-http2-compat-expect-continue.js

@@ -6,49 +6,90 @@ if (!common.hasCrypto)
 constassert=require('assert');
 consthttp2=require('http2');
 
-consttestResBody='other stuff!\n';
+{
+consttestResBody='other stuff!\n';
 
-// Checks the full 100-continue flow from client sending 'expect: 100-continue'
-// through server receiving it, sending back :status 100, writing the rest of
-// the request to finally the client receiving to.
+// Checks the full 100-continue flow from client sending 'expect: 100-continue'
+// through server receiving it, sending back :status 100, writing the rest of
+// the request to finally the client receiving to.
 
-constserver=http2.createServer();
+constserver=http2.createServer();
 
-letsentResponse=false;
+letsentResponse=false;
 
-server.on('request',common.mustCall((req,res)=>{
-res.end(testResBody);
-sentResponse=true;
-}));
+server.on('request',common.mustCall((req,res)=>{
+res.end(testResBody);
+sentResponse=true;
+}));
+
+server.listen(0);
+
+server.on('listening',common.mustCall(()=>{
+letbody='';
 
-server.listen(0);
+constclient=http2.connect(`http://localhost:${server.address().port}`);
+constreq=client.request({
+':method': 'POST',
+'expect': '100-continue'
+});
 
-server.on('listening',common.mustCall(()=>{
-letbody='';
+letgotContinue=false;
+req.on('continue',common.mustCall(()=>{
+gotContinue=true;
+}));
 
-constclient=http2.connect(`http://localhost:${server.address().port}`);
-constreq=client.request({
-':method': 'POST',
-'expect': '100-continue'
-});
+req.on('response',common.mustCall((headers)=>{
+assert.strictEqual(gotContinue,true);
+assert.strictEqual(sentResponse,true);
+assert.strictEqual(headers[':status'],200);
+req.end();
+}));
 
-letgotContinue=false;
-req.on('continue',common.mustCall(()=>{
-gotContinue=true;
+req.setEncoding('utf8');
+req.on('data',common.mustCall((chunk)=>{body+=chunk;}));
+req.on('end',common.mustCall(()=>{
+assert.strictEqual(body,testResBody);
+client.close();
+server.close();
+}));
 }));
+}
+
+{
+// Checks the full 100-continue flow from client sending 'expect: 100-continue'
+// through server receiving it and ending the request.
+
+constserver=http2.createServer();
 
-req.on('response',common.mustCall((headers)=>{
-assert.strictEqual(gotContinue,true);
-assert.strictEqual(sentResponse,true);
-assert.strictEqual(headers[':status'],200);
-req.end();
+server.on('request',common.mustCall((req,res)=>{
+res.end();
 }));
 
-req.setEncoding('utf8');
-req.on('data',common.mustCall((chunk)=>{body+=chunk;}));
-req.on('end',common.mustCall(()=>{
-assert.strictEqual(body,testResBody);
-client.close();
-server.close();
+server.listen(0);
+
+server.on('listening',common.mustCall(()=>{
+constclient=http2.connect(`http://localhost:${server.address().port}`);
+constreq=client.request({
+':path': '/',
+'expect': '100-continue'
+});
+
+letgotContinue=false;
+req.on('continue',common.mustCall(()=>{
+gotContinue=true;
+}));
+
+letgotResponse=false;
+req.on('response',common.mustCall(()=>{
+gotResponse=true;
+}));
+
+req.setEncoding('utf8');
+req.on('end',common.mustCall(()=>{
+assert.strictEqual(gotContinue,true);
+assert.strictEqual(gotResponse,true);
+client.close();
+server.close();
+}));
 }));
-}));
+}