Skip to content

Commit 49da459

Browse files
Trottruyadorno
authored andcommitted
test: improve pummel/test-timers.js
* use Date.now() instead of new Date() because only the timestamp is ever used, so we don't need the full Date object * use separate start times recorded for the two different test cases * improve assertion messages PR-URL: #35175 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Shingo Inoue <[email protected]>
1 parent 066148d commit 49da459

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

‎test/pummel/test-timers.js‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,11 @@ const assert = require('assert');
2626
constWINDOW=200;// Why does this need to be so big?
2727

2828

29-
conststarttime=newDate();
3029
{
30+
conststarttime=Date.now();
31+
3132
setTimeout(common.mustCall(function(){
32-
constendtime=newDate();
33+
constendtime=Date.now();
3334

3435
constdiff=endtime-starttime;
3536
assert.ok(diff>0);
@@ -46,21 +47,23 @@ const starttime = new Date();
4647
}
4748

4849
{
50+
conststarttime=Date.now();
51+
4952
letinterval_count=0;
5053

5154
setInterval(common.mustCall(function(){
5255
interval_count+=1;
53-
constendtime=newDate();
56+
constendtime=Date.now();
5457

5558
constdiff=endtime-starttime;
5659
assert.ok(diff>0);
5760
console.error(`diff: ${diff}`);
5861

5962
constt=interval_count*1000;
6063

61-
assert.strictEqual(t-WINDOW<diff&&diff<t+WINDOW,true);
64+
assert.ok(t-WINDOW<diff&&diff<t+WINDOW,`t: ${t}`);
6265

63-
assert.strictEqual(interval_count<=3,true);
66+
assert.ok(interval_count<=3,`interval_count: ${interval_count}`);
6467
if(interval_count===3)
6568
clearInterval(this);
6669
},3),1000);

0 commit comments

Comments
(0)