net: simplify net.Socket#end()

`writable` is already set by the streams side, and there is a handler waiting for the writable side to finish which already takes care of the other cleanup code that was previously there; both of these things can therefore be removed. PR-URL: #18708 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Matteo Collina <[email protected]>

Author: addaleax

lib/net.js

@@ -499,18 +499,10 @@ Socket.prototype._read = function(n){
 };
 
 
-Socket.prototype.end=function(data,encoding){
-stream.Duplex.prototype.end.call(this,data,encoding);
-this.writable=false;
+Socket.prototype.end=function(data,encoding,callback){
+stream.Duplex.prototype.end.call(this,data,encoding,callback);
 DTRACE_NET_STREAM_END(this);
 LTTNG_NET_STREAM_END(this);
-
-// just in case we're waiting for an EOF.
-if(this.readable&&!this._readableState.endEmitted)
-this.read(0);
-else
-maybeDestroy(this);
-
 returnthis;
 };