test_runner: test return value of mocked promisified timers

PR-URL: #50331 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Erick Wendel <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: mika-fischer

lib/internal/test_runner/mock/mock_timers.js

@@ -370,7 +370,7 @@ class MockTimers{
 returnMockDate;
 }
 
-async* #setIntervalPromisified(interval,startTime,options){
+async* #setIntervalPromisified(interval,result,options){
 constcontext=this;
 constemitter=newEventEmitter();
 if(options?.signal){
@@ -394,8 +394,7 @@ class MockTimers{
 
 consteventIt=EventEmitter.on(emitter,'data');
 constcallback=()=>{
-startTime+=interval;
-emitter.emit('data',startTime);
+emitter.emit('data',result);
 };
 
 consttimerId=this.#createTimer(true,callback,interval,options);

test/parallel/test-runner-mock-timers.js

@@ -407,6 +407,16 @@ describe('Mock Timers Test Suite', () =>{
 assert.strictEqual(result,expectedResult);
 });
 
+it('should always return the same result as the original timers/promises/setTimeout',async(t)=>{
+t.mock.timers.enable({apis: ['setTimeout']});
+for(constexpectedResultof[undefined,null,false,true,0,0n,1,1n,'','result',{}]){
+constp=nodeTimersPromises.setTimeout(2000,expectedResult);
+t.mock.timers.tick(2000);
+constresult=awaitp;
+assert.strictEqual(result,expectedResult);
+}
+});
+
 it('should abort operation if timers/promises/setTimeout received an aborted signal',async(t)=>{
 t.mock.timers.enable({apis: ['setTimeout']});
 constexpectedResult='result';
@@ -505,10 +515,11 @@ describe('Mock Timers Test Suite', () =>{
 
 constexpectedIterations=5;
 constinterval=1000;
-conststartedAt=Date.now();
+lettime=0;
 asyncfunctionrun(){
 consttimes=[];
-forawait(consttimeofnodeTimersPromises.setInterval(interval,startedAt)){
+forawait(const_ofnodeTimersPromises.setInterval(interval)){// eslint-disable-line no-unused-vars
+time+=interval;
 times.push(time);
 if(times.length===expectedIterations)break;
 }
@@ -525,7 +536,20 @@ describe('Mock Timers Test Suite', () =>{
 consttimeResults=awaitr;
 assert.strictEqual(timeResults.length,expectedIterations);
 for(letit=1;it<expectedIterations;it++){
-assert.strictEqual(timeResults[it-1],startedAt+(interval*it));
+assert.strictEqual(timeResults[it-1],interval*it);
+}
+});
+
+it('should always return the same result as the original timers/promises/setInterval',async(t)=>{
+t.mock.timers.enable({apis: ['setInterval']});
+for(constexpectedResultof[undefined,null,false,true,0,0n,1,1n,'','result',{}]){
+constintervalIterator=nodeTimersPromises.setInterval(2000,expectedResult);
+constp=intervalIterator.next();
+t.mock.timers.tick(2000);
+constresult=awaitp;
+awaitintervalIterator.return();
+assert.strictEqual(result.done,false);
+assert.strictEqual(result.value,expectedResult);
 }
 });
 
@@ -579,13 +603,12 @@ describe('Mock Timers Test Suite', () =>{
 constsignal=controller.signal;
 constinterval=200;
 constexpectedIterations=2;
-conststartedAt=Date.now();
-consttimeResults=[];
+letnumIterations=0;
 asyncfunctionrun(){
-constit=nodeTimersPromises.setInterval(interval,startedAt,{ signal });
-forawait(consttimeofit){
-timeResults.push(time);
-if(timeResults.length===5)break;
+constit=nodeTimersPromises.setInterval(interval,undefined,{ signal });
+forawait(const_ofit){// eslint-disable-line no-unused-vars
+numIterations+=1;
+if(numIterations===5)break;
 }
 }
 
@@ -601,11 +624,7 @@ describe('Mock Timers Test Suite', () =>{
 awaitassert.rejects(()=>r,{
 name: 'AbortError',
 });
-assert.strictEqual(timeResults.length,expectedIterations);
-
-for(letit=1;it<expectedIterations;it++){
-assert.strictEqual(timeResults[it-1],startedAt+(interval*it));
-}
+assert.strictEqual(numIterations,expectedIterations);
 });
 });
 });