child_process: handle undefined/null for fork() args

PR-URL: #22416Fixes: #20749 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Matheus Marchini <[email protected]>

Author: shobhitchittora

lib/child_process.js

@@ -69,6 +69,11 @@ exports.fork = function fork(modulePath /* , args, options */){
 args=arguments[pos++];
 }
 
+if(pos<arguments.length&&
+(arguments[pos]===undefined||arguments[pos]===null)){
+pos++;
+}
+
 if(pos<arguments.length&&arguments[pos]!=null){
 if(typeofarguments[pos]!=='object'){
 thrownewERR_INVALID_ARG_VALUE(`arguments[${pos}]`,arguments[pos]);

test/fixtures/child-process-echo-options.js

@@ -0,0 +1 @@
+process.send({env: process.env});

test/parallel/test-child-process-fork-options.js

@@ -0,0 +1,37 @@
+'use strict';
+constcommon=require('../common');
+constfixtures=require('../common/fixtures');
+
+// This test ensures that fork should parse options
+// correctly if args is undefined or null
+
+constassert=require('assert');
+const{ fork }=require('child_process');
+
+constexpectedEnv={foo: 'bar'};
+
+{
+constcp=fork(fixtures.path('child-process-echo-options.js'),undefined,
+{env: Object.assign({},process.env,expectedEnv)});
+
+cp.on('message',common.mustCall(({ env })=>{
+assert.strictEqual(env.foo,expectedEnv.foo);
+}));
+
+cp.on('exit',common.mustCall((code)=>{
+assert.strictEqual(code,0);
+}));
+}
+
+{
+constcp=fork(fixtures.path('child-process-echo-options.js'),null,
+{env: Object.assign({},process.env,expectedEnv)});
+
+cp.on('message',common.mustCall(({ env })=>{
+assert.strictEqual(env.foo,expectedEnv.foo);
+}));
+
+cp.on('exit',common.mustCall((code)=>{
+assert.strictEqual(code,0);
+}));
+}