lib: make sure close net server

PR-URL: #51929 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Author: theanarkh

lib/net.js

@@ -1773,6 +1773,7 @@ function Server(options, connectionListener){
 this._usingWorkers=false;
 this._workers=[];
 this._unref=false;
+this._listeningId=1;
 
 this.allowHalfOpen=options.allowHalfOpen||false;
 this.pauseOnConnect=!!options.pauseOnConnect;
@@ -1954,10 +1955,14 @@ function listenInCluster(server, address, port, addressType,
  backlog,
  ...options,
 };
+constlisteningId=server._listeningId;
 // Get the primary's server handle, and listen on it
 cluster._getServer(server,serverQuery,listenOnPrimaryHandle);
-
 functionlistenOnPrimaryHandle(err,handle){
+if(listeningId!==server._listeningId){
+handle.close();
+return;
+}
 err=checkBindError(err,port,handle);
 
 if(err){
@@ -2089,9 +2094,14 @@ Server.prototype.listen = function(...args){
 thrownewERR_INVALID_ARG_VALUE('options',options);
 };
 
-functionlookupAndListen(self,port,address,backlog,exclusive,flags){
+functionlookupAndListen(self,port,address,backlog,
+exclusive,flags){
 if(dns===undefined)dns=require('dns');
+constlisteningId=self._listeningId;
 dns.lookup(address,functiondoListen(err,ip,addressType){
+if(listeningId!==self._listeningId){
+return;
+}
 if(err){
 self.emit('error',err);
 }else{
@@ -2237,6 +2247,7 @@ Server.prototype.getConnections = function(cb){
 
 
 Server.prototype.close=function(cb){
+this._listeningId++;
 if(typeofcb==='function'){
 if(!this._handle){
 this.once('close',functionclose(){

test/parallel/test-net-server-close-before-calling-lookup-callback.js

@@ -0,0 +1,7 @@
+'use strict';
+
+constcommon=require('../common');
+constnet=require('net');
+// Process should exit because it does not create a real TCP server.
+// Paas localhost to ensure create TCP handle asynchronously because It causes DNS resolution.
+net.createServer().listen(0,'localhost',common.mustNotCall()).close();

test/parallel/test-net-server-close-before-ipc-response.js

@@ -0,0 +1,22 @@
+'use strict';
+
+constcommon=require('../common');
+constnet=require('net');
+constcluster=require('cluster');
+
+// Process should exit
+if(cluster.isPrimary){
+cluster.fork();
+}else{
+constsend=process.send;
+process.send=function(message){
+// listenOnPrimaryHandle in net.js should call handle.close()
+if(message.act==='close'){
+setImmediate(()=>{
+process.disconnect();
+});
+}
+returnsend.apply(this,arguments);
+};
+net.createServer().listen(0,common.mustNotCall()).close();
+}