net: implement capture rejections for 'connection' event

PR-URL: #27867 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: mcollina

lib/_http_server.js

@@ -359,10 +359,11 @@ Server.prototype.setTimeout = function setTimeout(msecs, callback){
 };
 
 Server.prototype[EE.captureRejectionSymbol]=function(
-err,event,req,res){
+err,event,...args){
 
 switch(event){
 case'request':
+const[,res]=args;
 if(!res.headersSent&&!res.writableEnded){
 // Don't leak headers.
 for(constnameofres.getHeaderNames()){
@@ -375,7 +376,8 @@ Server.prototype[EE.captureRejectionSymbol] = function(
 }
 break;
 default:
-this.emit('error',err);
+net.Server.prototype[Symbol.for('nodejs.rejection')]
+.call(this,err,event, ...args);
 }
 };
 

lib/net.js

@@ -1653,6 +1653,19 @@ function emitCloseNT(self){
 }
 
 
+Server.prototype[EventEmitter.captureRejectionSymbol]=function(
+err,event,sock){
+
+switch(event){
+case'connection':
+sock.destroy(err);
+break;
+default:
+this.emit('error',err);
+}
+};
+
+
 // Legacy alias on the C++ wrapper object. This is not public API, so we may
 // want to runtime-deprecate it at some point. There's no hurry, though.
 ObjectDefineProperty(TCP.prototype,'owner',{

test/parallel/test-net-server-capture-rejection.js

@@ -0,0 +1,27 @@
+'use strict';
+
+constcommon=require('../common');
+constassert=require('assert');
+constevents=require('events');
+const{ createServer, connect }=require('net');
+
+events.captureRejections=true;
+
+constserver=createServer(common.mustCall(async(sock)=>{
+server.close();
+
+const_err=newError('kaboom');
+sock.on('error',common.mustCall((err)=>{
+assert.strictEqual(err,_err);
+}));
+throw_err;
+}));
+
+server.listen(0,common.mustCall(()=>{
+constsock=connect(
+server.address().port,
+server.address().host
+);
+
+sock.on('close',common.mustCall());
+}));