http2: wait for secureConnect before initializing

PR-URL: #32958Fixes: #32922 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: bcoe

lib/_tls_wrap.js

@@ -467,6 +467,7 @@ function TLSSocket(socket, opts){
 this._securePending=false;
 this._newSessionPending=false;
 this._controlReleased=false;
+this.secureConnecting=true;
 this._SNICallback=null;
 this.servername=null;
 this.alpnProtocol=null;
@@ -1029,6 +1030,7 @@ function onServerSocketSecure(){
 
 if(!this.destroyed&&this._releaseControl()){
 debug('server emit secureConnection');
+this.secureConnecting=false;
 this._tlsOptions.server.emit('secureConnection',this);
 }
 }

lib/internal/http2/core.js

@@ -1152,7 +1152,7 @@ class Http2Session extends EventEmitter{
 socket.disableRenegotiation();
 
 constsetupFn=setupHandle.bind(this,socket,type,options);
-if(socket.connecting){
+if(socket.connecting||socket.secureConnecting){
 constconnectEvent=
 socketinstanceoftls.TLSSocket ? 'secureConnect' : 'connect';
 socket.once(connectEvent,()=>{

test/internet/test-http2-issue-32922.js

@@ -0,0 +1,80 @@
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+
+if(!common.hasCrypto)
+common.skip('missing crypto');
+
+consthttp2=require('http2');
+constnet=require('net');
+
+const{
+HTTP2_HEADER_PATH,
+}=http2.constants;
+
+// Create a normal session, as a control case
+functionnormalSession(cb){
+http2.connect('https://google.com',(clientSession)=>{
+leterror=null;
+constreq=clientSession.request({[HTTP2_HEADER_PATH]: '/'});
+req.on('error',(err)=>{
+error=err;
+});
+req.on('response',(_headers)=>{
+req.on('data',(_chunk)=>{});
+req.on('end',()=>{
+clientSession.close();
+returncb(error);
+});
+});
+});
+}
+normalSession(common.mustCall(function(err){
+assert.ifError(err);
+}));
+
+// Create a session using a socket that has not yet finished connecting
+functionsocketNotFinished(done){
+constsocket2=net.connect(443,'google.com');
+http2.connect('https://google.com',{ socket2 },(clientSession)=>{
+leterror=null;
+constreq=clientSession.request({[HTTP2_HEADER_PATH]: '/'});
+req.on('error',(err)=>{
+error=err;
+});
+req.on('response',(_headers)=>{
+req.on('data',(_chunk)=>{});
+req.on('end',()=>{
+clientSession.close();
+socket2.destroy();
+returndone(error);
+});
+});
+});
+}
+socketNotFinished(common.mustCall(function(err){
+assert.ifError(err);
+}));
+
+// Create a session using a socket that has finished connecting
+functionsocketFinished(done){
+constsocket=net.connect(443,'google.com',()=>{
+http2.connect('https://google.com',{ socket },(clientSession)=>{
+leterror=null;
+constreq=clientSession.request({[HTTP2_HEADER_PATH]: '/'});
+req.on('error',(err)=>{
+error=err;
+});
+req.on('response',(_headers)=>{
+req.on('data',(_chunk)=>{});
+req.on('end',()=>{
+clientSession.close();
+returndone(error);
+});
+});
+});
+});
+}
+socketFinished(common.mustCall(function(err){
+assert.ifError(err);
+}));