test: update test-child-process-windows-hide to use node:test

This commit updates test/parallel/test-child-process-windows-hide.js to use node:test. This allows the test to use the built in mocking functionality instead of managing spies manually. It also prevents multiple child processes from being spawned in parallel, which can be problematic in the CI. PR-URL: #56437 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: cjihrig

test/parallel/test-child-process-windows-hide.js

@@ -3,49 +3,48 @@
 constcommon=require('../common');
 constassert=require('assert');
 constcp=require('child_process');
+const{ test }=require('node:test');
 constinternalCp=require('internal/child_process');
 constcmd=process.execPath;
 constargs=['-p','42'];
 constoptions={windowsHide: true};
 
-// Since windowsHide isn't really observable, monkey patch spawn() and
-// spawnSync() to verify that the flag is being passed through correctly.
-constoriginalSpawn=internalCp.ChildProcess.prototype.spawn;
-constoriginalSpawnSync=internalCp.spawnSync;
+// Since windowsHide isn't really observable, this test relies on monkey
+// patching spawn() and spawnSync() to verify that the flag is being passed
+// through correctly.
 
-internalCp.ChildProcess.prototype.spawn=common.mustCall(function(options){
-assert.strictEqual(options.windowsHide,true);
-returnoriginalSpawn.apply(this,arguments);
-},2);
-
-internalCp.spawnSync=common.mustCall(function(options){
-assert.strictEqual(options.windowsHide,true);
-returnoriginalSpawnSync.apply(this,arguments);
-});
-
-{
+test('spawnSync() passes windowsHide correctly',(t)=>{
+constspy=t.mock.method(internalCp,'spawnSync');
 constchild=cp.spawnSync(cmd,args,options);
 
 assert.strictEqual(child.status,0);
 assert.strictEqual(child.signal,null);
 assert.strictEqual(child.stdout.toString().trim(),'42');
 assert.strictEqual(child.stderr.toString().trim(),'');
-}
+assert.strictEqual(spy.mock.calls.length,1);
+assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide,true);
+});
 
-{
+test('spawn() passes windowsHide correctly',(t,done)=>{
+constspy=t.mock.method(internalCp.ChildProcess.prototype,'spawn');
 constchild=cp.spawn(cmd,args,options);
 
 child.on('exit',common.mustCall((code,signal)=>{
 assert.strictEqual(code,0);
 assert.strictEqual(signal,null);
+assert.strictEqual(spy.mock.calls.length,1);
+assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide,true);
+done();
 }));
-}
+});
 
-{
-constcallback=common.mustSucceed((stdout,stderr)=>{
+test('execFile() passes windowsHide correctly',(t,done)=>{
+constspy=t.mock.method(internalCp.ChildProcess.prototype,'spawn');
+cp.execFile(cmd,args,options,common.mustSucceed((stdout,stderr)=>{
 assert.strictEqual(stdout.trim(),'42');
 assert.strictEqual(stderr.trim(),'');
-});
-
-cp.execFile(cmd,args,options,callback);
-}
+assert.strictEqual(spy.mock.calls.length,1);
+assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide,true);
+done();
+}));
+});