test_runner: disallow array in run options

PR-URL: #49935 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: rluvaton

lib/internal/test_runner/runner.js

@@ -435,10 +435,9 @@ function watchFiles(testFiles, opts){
 returnfilesWatcher;
 }
 
-functionrun(options){
-if(options===null||typeofoptions!=='object'){
-options=kEmptyObject;
-}
+functionrun(options=kEmptyObject){
+validateObject(options,'options');
+
 let{ testNamePatterns, shard }=options;
 const{ concurrency, timeout, signal, files, inspectPort, watch, setup, only }=options;
 

test/parallel/test-runner-run.mjs

@@ -8,7 +8,6 @@ import assert from 'node:assert'
 consttestFixtures=fixtures.path('test-runner');
 
 describe('require(\'node:test\').run',{concurrency: true},()=>{
-
 it('should run with no tests',async()=>{
 conststream=run({files: []});
 stream.on('test:fail',common.mustNotCall());
@@ -65,13 +64,6 @@ describe('require(\'node:test\').run',{concurrency: true }, () =>{
 forawait(const_ofstream);
 });
 
-it('should validate files',async()=>{
-[Symbol(),{},()=>{},0,1,0n,1n,'','1',Promise.resolve([]),true,false]
-.forEach((files)=>assert.throws(()=>run({ files }),{
-code: 'ERR_INVALID_ARG_TYPE'
-}));
-});
-
 it('should be piped with dot',async()=>{
 constresult=awaitrun({
 files: [join(testFixtures,'default-behavior/test/random.cjs')]
@@ -437,4 +429,20 @@ describe('require(\'node:test\').run',{concurrency: true }, () =>{
 assert.deepStrictEqual(executedTestFiles.sort(),[...shardsTestsFiles].sort());
 });
 });
+
+describe('validation',()=>{
+it('should only allow array in options.files',async()=>{
+[Symbol(),{},()=>{},0,1,0n,1n,'','1',Promise.resolve([]),true,false]
+.forEach((files)=>assert.throws(()=>run({ files }),{
+code: 'ERR_INVALID_ARG_TYPE'
+}));
+});
+
+it('should only allow object as options',()=>{
+[Symbol(),[],()=>{},0,1,0n,1n,'','1',true,false]
+.forEach((options)=>assert.throws(()=>run(options),{
+code: 'ERR_INVALID_ARG_TYPE'
+}));
+});
+});
 });